change PVP code to make it more reusable

2 files changed, 37 insertions, 8 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/auth/servlet/AbstractProcessEngineSignalController.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/auth/servlet/AbstractProcessEngineSignalController.java
index 8b96b884e..6be0fce90 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/auth/servlet/AbstractProcessEngineSignalController.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/auth/servlet/AbstractProcessEngineSignalController.java
@@ -23,7 +23,7 @@ import at.gv.egovernment.moa.logging.Logger;
  */

 public abstract class AbstractProcessEngineSignalController extends AbstractController {

 		

-	@Autowired ProcessEngine processEngine;

+	@Autowired protected ProcessEngine processEngine;

 	

 	protected void signalProcessManagement(HttpServletRequest req, HttpServletResponse resp) throws IOException {

 		String pendingRequestID = StringEscapeUtils.escapeHtml(getPendingRequestId(req));

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/signer/IDPCredentialProvider.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/signer/IDPCredentialProvider.java
index 8fb4ec3cf..abc4eb4a9 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/signer/IDPCredentialProvider.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/signer/IDPCredentialProvider.java
@@ -29,6 +29,7 @@ import org.springframework.stereotype.Service;
 
 import at.gv.egovernment.moa.id.config.auth.AuthConfiguration;
 import at.gv.egovernment.moa.util.FileUtils;
+import at.gv.egovernment.moa.util.MiscUtil;
 
 @Service("IDPCredentialProvider")
 public class IDPCredentialProvider extends AbstractCredentialProvider {	
@@ -70,7 +71,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KS_PASS).trim();
+		String value = props.getProperty(IDP_KS_PASS);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)
@@ -81,7 +86,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KEYALIASMETADATA).trim();
+		String value = props.getProperty(IDP_KEYALIASMETADATA);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)
@@ -92,7 +101,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KEY_PASSMETADATA).trim();
+		String value = props.getProperty(IDP_KEY_PASSMETADATA);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)
@@ -103,7 +116,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KEYALIASASSERTION).trim();
+		String value = props.getProperty(IDP_KEYALIASASSERTION);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)
@@ -114,7 +131,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KEY_PASSASSERTION).trim();
+		String value = props.getProperty(IDP_KEY_PASSASSERTION);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)
@@ -125,7 +146,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KEYALIASENCRYTPION).trim();
+		String value = props.getProperty(IDP_KEYALIASENCRYTPION);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)
@@ -136,7 +161,11 @@ public class IDPCredentialProvider extends AbstractCredentialProvider {
 		if (props == null)
 			props = authConfig.getGeneralPVP2ProperiesConfig();
 		
-		return props.getProperty(IDP_KEYALIASENCRYTPION).trim();
+		String value = props.getProperty(IDP_KEY_PASSENCRYTPION);
+		if (MiscUtil.isNotEmpty(value))
+			return value.trim();
+		else
+			return null;
 	}
 
 	/* (non-Javadoc)