first short changes for BRZ

 *use different SystemConfigParam for moa-id-proxy
 *allow legacy request with no SL-template (use it from OA config)

Bugfix:
 *general PVP2 config is not reloaded from database
 *use idp entityID in as issuer in AuthnResponse

1 files changed, 13 insertions, 16 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/config/PVPConfiguration.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/config/PVPConfiguration.java
index 769e36fc1..5d71b915f 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/config/PVPConfiguration.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/config/PVPConfiguration.java
@@ -25,9 +25,7 @@ package at.gv.egovernment.moa.id.protocols.pvp2x.config;
 import iaik.x509.X509Certificate;
 
 import java.io.File;
-import java.io.IOException;
 import java.net.URL;
-import java.net.URLClassLoader;
 import java.security.cert.CertificateException;
 import java.util.ArrayList;
 import java.util.List;
@@ -50,7 +48,6 @@ import org.opensaml.saml2.metadata.TelephoneNumber;
 
 import at.gv.egovernment.moa.id.commons.db.dao.config.Contact;
 import at.gv.egovernment.moa.id.commons.db.dao.config.OAPVP2;
-import at.gv.egovernment.moa.id.commons.db.dao.config.PVP2;
 import at.gv.egovernment.moa.id.config.ConfigurationException;
 import at.gv.egovernment.moa.id.config.auth.AuthConfigurationProvider;
 import at.gv.egovernment.moa.id.config.auth.OAAuthParameter;
@@ -111,12 +108,12 @@ public class PVPConfiguration {
 
 	private static String moaIDVersion = null;
 	
-	PVP2 generalpvpconfigdb;
+	//PVP2 generalpvpconfigdb;
 	Properties props;
 	
 	private PVPConfiguration() {
 		 try {
-			generalpvpconfigdb = AuthConfigurationProvider.getInstance().getGeneralPVP2DBConfig();
+			//generalpvpconfigdb = AuthConfigurationProvider.getInstance().getGeneralPVP2DBConfig();
 			props = AuthConfigurationProvider.getInstance().getGeneralPVP2ProperiesConfig();
 			
 		} catch (ConfigurationException e) {
@@ -124,8 +121,8 @@ public class PVPConfiguration {
 		}
 	}
 	
-	public String getIDPPublicPath() {
-		String publicPath = generalpvpconfigdb.getPublicURLPrefix();
+	public String getIDPPublicPath() throws ConfigurationException {
+		String publicPath = AuthConfigurationProvider.getInstance().getGeneralPVP2DBConfig().getPublicURLPrefix();
 		if(publicPath != null) {
 			if(publicPath.endsWith("/")) {
 				int length = publicPath.length();
@@ -135,15 +132,15 @@ public class PVPConfiguration {
 		return publicPath;
 	}
 
-	public String getIDPSSOPostService() {
+	public String getIDPSSOPostService() throws ConfigurationException {
 		return getIDPPublicPath() + PVP2_POST;
 	}
 
-	public String getIDPSSORedirectService() {
+	public String getIDPSSORedirectService() throws ConfigurationException {
 		return getIDPPublicPath() + PVP2_REDIRECT;
 	}
 	
-	public String getIDPSSOMetadataService() {
+	public String getIDPSSOMetadataService() throws ConfigurationException {
 		return getIDPPublicPath() + PVP2_METADATA;
 	}
 
@@ -171,13 +168,13 @@ public class PVPConfiguration {
 		return props.getProperty(IDP_KEY_PASSASSERTION);
 	}
 
-	public String getIDPIssuerName() {
+	public String getIDPIssuerName() throws ConfigurationException {
 		
 		if (moaIDVersion == null) {
 			moaIDVersion = parseMOAIDVersionFromManifest();
 		}
 		
-		return generalpvpconfigdb.getIssuerName() + moaIDVersion;
+		return AuthConfigurationProvider.getInstance().getGeneralPVP2DBConfig().getIssuerName() + moaIDVersion;
 	}
 
 	public List<String> getMetadataFiles() {
@@ -250,10 +247,10 @@ public class PVPConfiguration {
 		}
 	}
 
-	public List<ContactPerson> getIDPContacts() {
+	public List<ContactPerson> getIDPContacts() throws ConfigurationException {
 		List<ContactPerson> list = new ArrayList<ContactPerson>();
 
-		List<Contact> contacts = generalpvpconfigdb.getContact();
+		List<Contact> contacts = AuthConfigurationProvider.getInstance().getGeneralPVP2DBConfig().getContact();
 		
 		if (contacts != null) {
 		
@@ -344,10 +341,10 @@ public class PVPConfiguration {
 		return list;
 	}
 
-	public Organization getIDPOrganisation() {
+	public Organization getIDPOrganisation() throws ConfigurationException {
 		Organization org = SAML2Utils.createSAMLObject(Organization.class);
 
-		at.gv.egovernment.moa.id.commons.db.dao.config.Organization organisation = generalpvpconfigdb.getOrganization();
+		at.gv.egovernment.moa.id.commons.db.dao.config.Organization organisation = AuthConfigurationProvider.getInstance().getGeneralPVP2DBConfig().getOrganization();
 		
 		String org_name = null;
 		String org_dispname = null;