First untested part: Refactor authentication modules and process management to Spring

1 files changed, 14 insertions, 8 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/SingleLogOutAction.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/SingleLogOutAction.java
index 582f5939d..8928aaeca 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/SingleLogOutAction.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/pvp2x/SingleLogOutAction.java
@@ -37,6 +37,8 @@ import org.hibernate.Transaction;
 import org.opensaml.saml2.core.LogoutRequest;
 import org.opensaml.saml2.core.LogoutResponse;
 import org.opensaml.saml2.metadata.SingleLogoutService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
 
 import at.gv.egovernment.moa.id.auth.MOAIDAuthConstants;
 import at.gv.egovernment.moa.id.auth.data.AuthenticationSession;
@@ -57,8 +59,8 @@ import at.gv.egovernment.moa.id.protocols.pvp2x.builder.SingleLogOutBuilder;
 import at.gv.egovernment.moa.id.protocols.pvp2x.exceptions.SLOException;
 import at.gv.egovernment.moa.id.protocols.pvp2x.messages.MOARequest;
 import at.gv.egovernment.moa.id.protocols.pvp2x.messages.MOAResponse;
-import at.gv.egovernment.moa.id.storage.AssertionStorage;
-import at.gv.egovernment.moa.id.storage.AuthenticationSessionStoreage;
+import at.gv.egovernment.moa.id.storage.IAuthenticationSessionStoreage;
+import at.gv.egovernment.moa.id.storage.ITransactionStorage;
 import at.gv.egovernment.moa.id.util.Random;
 import at.gv.egovernment.moa.logging.Logger;
 import at.gv.egovernment.moa.util.MiscUtil;
@@ -68,8 +70,14 @@ import at.gv.egovernment.moa.util.URLEncoder;
  * @author tlenz
  *
  */
+@Service("pvpSingleLogOutService")
 public class SingleLogOutAction implements IAction {
 
+	@Autowired private SSOManager ssomanager;
+	@Autowired private AuthenticationManager authManager;
+	@Autowired private IAuthenticationSessionStoreage authenticationSessionStorage;
+	@Autowired private ITransactionStorage transactionStorage;
+	
 	/* (non-Javadoc)
 	 * @see at.gv.egovernment.moa.id.moduls.IAction#processRequest(at.gv.egovernment.moa.id.moduls.IRequest, javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse, at.gv.egovernment.moa.id.data.IAuthData)
 	 */
@@ -87,7 +95,7 @@ public class SingleLogOutAction implements IAction {
 			LogoutRequest logOutReq = (LogoutRequest) samlReq.getSamlRequest();
 				
 			AuthenticationSession session = 
-					AuthenticationSessionStoreage.searchMOASessionWithNameIDandOAID(
+					authenticationSessionStorage.searchMOASessionWithNameIDandOAID(
 							logOutReq.getIssuer().getValue(), 
 							logOutReq.getNameID().getValue());
 				
@@ -96,7 +104,6 @@ public class SingleLogOutAction implements IAction {
 							+ logOutReq.getNameID().getValue() + " and OA " 
 							+ logOutReq.getIssuer().getValue());
 					Logger.info("Search active SSO session with SSO session cookie");
-					SSOManager ssomanager =  SSOManager.getInstance();
 					String ssoID = ssomanager.getSSOSessionID(httpReq);
 					if (MiscUtil.isEmpty(ssoID)) {
 						Logger.info("Can not find active Session. Single LogOut not possible!");
@@ -110,7 +117,7 @@ public class SingleLogOutAction implements IAction {
 					} else {
 						String moasession = ssomanager.getMOASession(ssoID);						
 						try {
-							session = AuthenticationSessionStoreage.getSession(moasession);
+							session = authenticationSessionStorage.getSession(moasession);
 														
 						} catch (MOADatabaseException e) {
 							Logger.info("Can not find active Session. Single LogOut not possible!");
@@ -124,8 +131,7 @@ public class SingleLogOutAction implements IAction {
 						}						
 					}					
 				}
-
-				AuthenticationManager authManager = AuthenticationManager.getInstance();
+				
 				authManager.performSingleLogOut(httpReq, httpResp, session, pvpReq);
 							
 			} else if (pvpReq.getRequest() instanceof MOAResponse &&
@@ -235,7 +241,7 @@ public class SingleLogOutAction implements IAction {
 							        else
 							        	statusCode  = MOAIDAuthConstants.SLOSTATUS_ERROR;
 
-									AssertionStorage.getInstance().put(artifact, statusCode);
+									transactionStorage.put(artifact, statusCode);
 							        redirectURL = addURLParameter(redirectURL, MOAIDAuthConstants.PARAM_SLOSTATUS, artifact);
 							        
 								}