refactor MOA-ID AuthConfiguration

1 files changed, 79 insertions, 74 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/config/auth/AuthConfigurationProvider.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/config/auth/AuthConfigurationProvider.java
index 087b331b5..81a3dad8f 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/config/auth/AuthConfigurationProvider.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/config/auth/AuthConfigurationProvider.java
@@ -67,10 +67,11 @@ import org.hibernate.cfg.Configuration;
 
 import at.gv.egovernment.moa.id.auth.AuthenticationServer;
 import at.gv.egovernment.moa.id.auth.MOAIDAuthConstants;
+import at.gv.egovernment.moa.id.auth.modules.internal.tasks.GetMISSessionIDTask;
+import at.gv.egovernment.moa.id.commons.config.MOAIDConfigurationConstants;
 import at.gv.egovernment.moa.id.commons.db.ConfigurationDBRead;
 import at.gv.egovernment.moa.id.commons.db.ConfigurationDBUtils;
 import at.gv.egovernment.moa.id.commons.db.NewConfigurationDBWrite;
-import at.gv.egovernment.moa.id.commons.db.MOAIDConfigurationConstants;
 import at.gv.egovernment.moa.id.commons.db.MOASessionDBUtils;
 import at.gv.egovernment.moa.id.commons.db.NewConfigurationDBRead;
 import at.gv.egovernment.moa.id.commons.db.StatisticLogDBUtils;
@@ -105,6 +106,7 @@ import at.gv.egovernment.moa.id.commons.db.dao.session.OldSSOSessionIDStore;
 import at.gv.egovernment.moa.id.commons.db.dao.statistic.StatisticLog;
 import at.gv.egovernment.moa.id.config.ConfigurationException;
 import at.gv.egovernment.moa.id.config.ConfigurationProvider;
+import at.gv.egovernment.moa.id.config.ConfigurationProviderImpl;
 import at.gv.egovernment.moa.id.config.ConfigurationUtils;
 import at.gv.egovernment.moa.id.config.ConnectionParameter;
 import at.gv.egovernment.moa.id.config.ConnectionParameterForeign;
@@ -139,8 +141,10 @@ import com.fasterxml.jackson.annotation.JsonIgnore;
  * @author Stefan Knirsch
  * 
  * @version $Id$
+ * 
+ *@deprecated  Use {@link AuthConfigProviderFactory} instead
  */
-public class AuthConfigurationProvider extends ConfigurationProvider implements AuthConfiguration {
+public class AuthConfigurationProvider extends ConfigurationProviderImpl implements AuthConfiguration {
 	
 //  /**  DEFAULT_ENCODING is "UTF-8" */
 //  private static final String DEFAULT_ENCODING="UTF-8";
@@ -419,78 +423,79 @@ public class AuthConfigurationProvider extends ConfigurationProvider implements
 		}
 		
 		
-		//check if XML config should be used
-		if (MiscUtil.isNotEmpty(legacyconfig) || MiscUtil.isNotEmpty(xmlconfig)) {
-			Logger.warn("WARNING! MOA-ID 2.0 is started with XML configuration. This setup overstrike the actual configuration in the Database!");
-			//moaidconfig = ConfigurationDBRead.getMOAIDConfiguration();
-			moaidconfig = NewConfigurationDBRead.getMOAIDConfiguration();
-			if (moaidconfig.getAuthComponentGeneral()!= null || moaidconfig.getChainingModes() != null || moaidconfig.getTrustedCACertificates() != null || moaidconfig.getDefaultBKUs() != null
-					 || moaidconfig.getSLRequestTemplates() != null || moaidconfig.getTimestampItem() != null || moaidconfig.getPvp2RefreshItem() != null) {
-				
-				// ConfigurationDBUtils.delete(moaidconfig);
-				for(String key : MOAIDConfigurationConstants.getMOAIDConfigurationKeys()){
-					NewConfigurationDBWrite.delete(key);
-				}
-			}
-				
-			
-			//List<OnlineApplication> oas = ConfigurationDBRead.getAllOnlineApplications();
-			List<OnlineApplication> oas =  NewConfigurationDBRead.getAllOnlineApplications();
-			if (oas != null && oas.size() > 0) {
-				// for (OnlineApplication oa : oas)
-				// 		ConfigurationDBUtils.delete(oa);
-				NewConfigurationDBWrite.delete(MOAIDConfigurationConstants.ONLINE_APPLICATIONS_KEY);
-			}
-		}
-		
-		//load legacy config if it is configured
-		if (MiscUtil.isNotEmpty(legacyconfig)) {
-			Logger.warn("WARNING! MOA-ID 2.0 is started with legacy configuration. This setup is not recommended!");
-			
-			MOAIDConfiguration moaconfig = BuildFromLegacyConfig.build(new File(legacyconfig), rootConfigFileDir, null);
-			
-			List<OnlineApplication> oas = moaconfig.getOnlineApplication();
-			// for (OnlineApplication oa : oas)
-			// 		ConfigurationDBUtils.save(oa);
-			NewConfigurationDBWrite.saveOnlineApplications(oas);
-
-			moaconfig.setOnlineApplication(null);	
-		//	ConfigurationDBUtils.save(moaconfig);
-			NewConfigurationDBWrite.save(moaconfig);
-			
-			Logger.info("Legacy Configuration load is completed.");
-			
-	
-		}
-	
-		//load MOA-ID 2.x config from XML
-		if (MiscUtil.isNotEmpty(xmlconfig)) {
-			Logger.warn("Load configuration from MOA-ID 2.x XML configuration");
-		
-			try {
-				JAXBContext jc = JAXBContext.newInstance("at.gv.egovernment.moa.id.commons.db.dao.config");
-				Unmarshaller m = jc.createUnmarshaller();
-				File file = new File(xmlconfig); 
-				MOAIDConfiguration moaconfig = (MOAIDConfiguration) m.unmarshal(file);
-				//ConfigurationDBUtils.save(moaconfig);
-				
-				List<OnlineApplication> importoas = moaconfig.getOnlineApplication();
-				// for (OnlineApplication importoa : importoas) {
-				// 		ConfigurationDBUtils.saveOrUpdate(importoa);
-				// }
-
-				NewConfigurationDBWrite.saveOnlineApplications(importoas);
-				
-				moaconfig.setOnlineApplication(null);
-				//ConfigurationDBUtils.saveOrUpdate(moaconfig);
-				NewConfigurationDBWrite.save(moaconfig);
-				
-			} catch (Exception e) {
-				Logger.warn("MOA-ID XML configuration can not be loaded from File.", e);
-				throw new ConfigurationException("config.02", null);
-			}
-			Logger.info("XML Configuration load is completed.");
-		}
+		//TODO: removed in MOA-ID 3.x
+//		//check if XML config should be used
+//		if (MiscUtil.isNotEmpty(legacyconfig) || MiscUtil.isNotEmpty(xmlconfig)) {
+//			Logger.warn("WARNING! MOA-ID 2.0 is started with XML configuration. This setup overstrike the actual configuration in the Database!");
+//			//moaidconfig = ConfigurationDBRead.getMOAIDConfiguration();
+//			moaidconfig = NewConfigurationDBRead.getMOAIDConfiguration();
+//			if (moaidconfig.getAuthComponentGeneral()!= null || moaidconfig.getChainingModes() != null || moaidconfig.getTrustedCACertificates() != null || moaidconfig.getDefaultBKUs() != null
+//					 || moaidconfig.getSLRequestTemplates() != null || moaidconfig.getTimestampItem() != null || moaidconfig.getPvp2RefreshItem() != null) {
+//				
+//				// ConfigurationDBUtils.delete(moaidconfig);
+//				for(String key : MOAIDConfigurationConstants.getMOAIDConfigurationKeys()){
+//					NewConfigurationDBWrite.delete(key);
+//				}
+//			}
+//				
+//			
+//			//List<OnlineApplication> oas = ConfigurationDBRead.getAllOnlineApplications();
+//			List<OnlineApplication> oas =  NewConfigurationDBRead.getAllOnlineApplications();
+//			if (oas != null && oas.size() > 0) {
+//				// for (OnlineApplication oa : oas)
+//				// 		ConfigurationDBUtils.delete(oa);
+//				NewConfigurationDBWrite.delete(MOAIDConfigurationConstants.ONLINE_APPLICATIONS_KEY);
+//			}
+//		}
+//		
+//		//load legacy config if it is configured
+//		if (MiscUtil.isNotEmpty(legacyconfig)) {
+//			Logger.warn("WARNING! MOA-ID 2.0 is started with legacy configuration. This setup is not recommended!");
+//			
+//			MOAIDConfiguration moaconfig = BuildFromLegacyConfig.build(new File(legacyconfig), rootConfigFileDir, null);
+//			
+//			List<OnlineApplication> oas = moaconfig.getOnlineApplication();
+//			// for (OnlineApplication oa : oas)
+//			// 		ConfigurationDBUtils.save(oa);
+//			NewConfigurationDBWrite.saveOnlineApplications(oas);
+//
+//			moaconfig.setOnlineApplication(null);	
+//		//	ConfigurationDBUtils.save(moaconfig);
+//			NewConfigurationDBWrite.save(moaconfig);
+//			
+//			Logger.info("Legacy Configuration load is completed.");
+//			
+//	
+//		}
+//	
+//		//load MOA-ID 2.x config from XML
+//		if (MiscUtil.isNotEmpty(xmlconfig)) {
+//			Logger.warn("Load configuration from MOA-ID 2.x XML configuration");
+//		
+//			try {
+//				JAXBContext jc = JAXBContext.newInstance("at.gv.egovernment.moa.id.commons.db.dao.config");
+//				Unmarshaller m = jc.createUnmarshaller();
+//				File file = new File(xmlconfig); 
+//				MOAIDConfiguration moaconfig = (MOAIDConfiguration) m.unmarshal(file);
+//				//ConfigurationDBUtils.save(moaconfig);
+//				
+//				List<OnlineApplication> importoas = moaconfig.getOnlineApplication();
+//				// for (OnlineApplication importoa : importoas) {
+//				// 		ConfigurationDBUtils.saveOrUpdate(importoa);
+//				// }
+//
+//				NewConfigurationDBWrite.saveOnlineApplications(importoas);
+//				
+//				moaconfig.setOnlineApplication(null);
+//				//ConfigurationDBUtils.saveOrUpdate(moaconfig);
+//				NewConfigurationDBWrite.save(moaconfig);
+//				
+//			} catch (Exception e) {
+//				Logger.warn("MOA-ID XML configuration can not be loaded from File.", e);
+//				throw new ConfigurationException("config.02", null);
+//			}
+//			Logger.info("XML Configuration load is completed.");
+//		}
 		
 		reloadDataBaseConfig();