First untested part: Refactor authentication modules and process management to Spring

1 files changed, 16 insertions, 30 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/advancedlogging/MOAReversionLogger.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/advancedlogging/MOAReversionLogger.java
index 7ac026888..17e39f766 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/advancedlogging/MOAReversionLogger.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/advancedlogging/MOAReversionLogger.java
@@ -27,10 +27,12 @@ import java.util.Arrays;
 import java.util.Date;
 import java.util.List;
 
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
 import at.gv.e_government.reference.namespace.mandates._20040701_.Mandate;
 import at.gv.egovernment.moa.id.auth.data.IdentityLink;
-import at.gv.egovernment.moa.id.config.ConfigurationException;
-import at.gv.egovernment.moa.id.config.auth.AuthConfigurationProviderFactory;
+import at.gv.egovernment.moa.id.config.auth.AuthConfiguration;
 import at.gv.egovernment.moa.id.config.auth.IOAAuthParameters;
 import at.gv.egovernment.moa.id.data.MISMandate;
 import at.gv.egovernment.moa.id.moduls.IRequest;
@@ -42,9 +44,10 @@ import at.gv.egovernment.moa.util.MiscUtil;
  * @author tlenz
  *
  */
+@Service("MOAReversionLogger")
 public class MOAReversionLogger {
-
-	private static MOAReversionLogger instance = null; 
+	
+	@Autowired protected AuthConfiguration authConfig;
 	
 	private static final List<Integer> defaultEventCodes = Arrays.asList(
 			MOAIDEventConstants.SESSION_CREATED, 
@@ -69,17 +72,6 @@ public class MOAReversionLogger {
 			MOAIDEventConstants.AUTHPROCESS_STORK_REQUESTED,
 			MOAIDEventConstants.AUTHPROCESS_SERVICEPROVIDER
 	);
-	
-	
-	public static synchronized MOAReversionLogger getInstance() {
-		if (instance == null) {
-			instance = new MOAReversionLogger();
-			MOAIDEventLog.reload();
-			
-		}			
-		
-		return instance;
-	}
 			
 	public void logEvent(IOAAuthParameters oaConfig, 
 			int eventCode, String message) {
@@ -91,8 +83,8 @@ public class MOAReversionLogger {
 			int eventCode) {		
 			if (selectOASpecificEventCodes(oaConfig).contains(eventCode))
 			MOAIDEventLog.logEvent(MOAIDEventLog.createNewEvent(new Date().getTime(), eventCode, 
-					pendingRequest.getSessionIdentifier(), 
-					pendingRequest.getRequestID()));
+					pendingRequest.getUniqueSessionIdentifier(), 
+					pendingRequest.getUniqueTransactionIdentifier()));
 									
 	}
 	
@@ -101,8 +93,8 @@ public class MOAReversionLogger {
 		if (selectOASpecificEventCodes(oaConfig).contains(eventCode))
 			MOAIDEventLog.logEvent(MOAIDEventLog.createNewEvent(new Date().getTime(), eventCode,
 					message,
-					pendingRequest.getSessionIdentifier(), 
-					pendingRequest.getRequestID()
+					pendingRequest.getUniqueSessionIdentifier(), 
+					pendingRequest.getUniqueTransactionIdentifier()
 					));
 									
 	}
@@ -140,8 +132,8 @@ public class MOAReversionLogger {
 	 */
 	public void logEvent(IRequest pendingRequest, int eventCode) {
 		MOAIDEventLog.logEvent(MOAIDEventLog.createNewEvent(new Date().getTime(), eventCode, 
-				pendingRequest.getSessionIdentifier(), 
-				pendingRequest.getRequestID()));
+				pendingRequest.getUniqueSessionIdentifier(), 
+				pendingRequest.getUniqueTransactionIdentifier()));
 		
 	}
 	
@@ -249,15 +241,9 @@ public class MOAReversionLogger {
 	}
 
 	public List<Integer> getDefaulttReversionsLoggingEventCodes() {
-		try {
-			List<Integer> configuredDefaultEventCodes = AuthConfigurationProviderFactory.getInstance().getDefaultRevisionsLogEventCodes();
-			if (configuredDefaultEventCodes != null)
-				return configuredDefaultEventCodes;
-			
-		} catch (ConfigurationException e) {
-			Logger.error("Access to configuration FAILED.", e);
-			
-		}
+		List<Integer> configuredDefaultEventCodes = authConfig.getDefaultRevisionsLogEventCodes();
+		if (configuredDefaultEventCodes != null)
+			return configuredDefaultEventCodes;
 		
 		return defaultEventCodes;
 	}