Clean up `Connector` usages (#90)

* migrate all connector-string uses to Connector enum, and fail early for unsupported connectors

* extra null guards + clean up equals for enums

* unify the parameter checking for jks too

* make empty/null inputs fail earlier

* exception instead of empty return

1 files changed, 12 insertions, 3 deletions

diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/api/ws/PDFASSignParameters.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/api/ws/PDFASSignParameters.java
index f72804ec..0db5673c 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/api/ws/PDFASSignParameters.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/api/ws/PDFASSignParameters.java
@@ -25,10 +25,12 @@ package at.gv.egiz.pdfas.api.ws;
 
 import java.io.Serializable;
 import java.util.Arrays;
+import java.util.Objects;
 
 import jakarta.xml.bind.annotation.XmlElement;
 import jakarta.xml.bind.annotation.XmlEnumValue;
 import jakarta.xml.bind.annotation.XmlType;
+import lombok.NonNull;
 
 @XmlType(name="SignParameters")
 public class PDFASSignParameters implements Serializable {
@@ -57,7 +59,7 @@ public class PDFASSignParameters implements Serializable {
 		
 		private final String name;       
 
-	    private Connector(String s) {
+	    Connector(String s) {
 	        name = s;
 	    }
 
@@ -70,12 +72,19 @@ public class PDFASSignParameters implements Serializable {
 	    }
 	    
 	    public static Connector fromString(String value) {
-	      return Arrays.asList(Connector.values()).stream()
+	      return Arrays.stream(Connector.values())
 	        .filter(el -> el.toString().equalsIgnoreCase(value))
 	        .findFirst()
-	        .get();
+			  .orElse(null);
 	      
 	    }
+
+		public static boolean isAsynchronous(@NonNull Connector c) {
+			return switch (Objects.requireNonNull(c)) {
+				case JKS, MOA -> false;
+				case BKU, MOBILEBKU, ONLINEBKU, SECLAYER20 -> true;
+			};
+		}
 	    
 	}