diff options
author | Christof Rabensteiner <christof.rabensteiner@iaik.tugraz.at> | 2019-08-28 13:34:41 +0200 |
---|---|---|
committer | Christof Rabensteiner <christof.rabensteiner@iaik.tugraz.at> | 2019-08-28 13:36:35 +0200 |
commit | 70e8a1b80fea9d61c46dbd55aa1b461a8bb3a0f7 (patch) | |
tree | d653c457ebf7331d7aa07b9c6f1ea122312480e3 /src/test | |
parent | ff0a32339c4e8dbc81be89a38990f3963c285121 (diff) | |
download | moa-zs-70e8a1b80fea9d61c46dbd55aa1b461a8bb3a0f7.tar.gz moa-zs-70e8a1b80fea9d61c46dbd55aa1b461a8bb3a0f7.tar.bz2 moa-zs-70e8a1b80fea9d61c46dbd55aa1b461a8bb3a0f7.zip |
Fixes and Refactoring
- JAXB Hack: Handle InterruptionException properly (as in [1], "Dont
swallow Interrupts")
- Mzs2MsgConverter: Rename convert(Person) to
convertReceiverPerson(Person) to emphasize that this method can only
be used to convert Receiver Persons (Reminder: Receiver Persons are
PhysicalPersons / CorporateBodies. SenderPersons can also be
Authorities)
- Mzs2MsgConverter: Remove assertion because not needed anymore.
- Refactor: Move mzs:DeliveryRequest validation out ouf augmenter and
into service.
- Refactor: Create a single entry point for validating a
mzs:DeliveryRequest.
- Remove unused imports.
- Fix log messages.
[1] https://www.ibm.com/developerworks/java/library/j-jtp05236/index.html?ca=drs-#2.1
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/java/at/gv/egiz/moazs/DeliveryRequestAugmenterTest.java | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/test/java/at/gv/egiz/moazs/DeliveryRequestAugmenterTest.java b/src/test/java/at/gv/egiz/moazs/DeliveryRequestAugmenterTest.java index 2e9dd80..cda334a 100644 --- a/src/test/java/at/gv/egiz/moazs/DeliveryRequestAugmenterTest.java +++ b/src/test/java/at/gv/egiz/moazs/DeliveryRequestAugmenterTest.java @@ -29,9 +29,6 @@ public class DeliveryRequestAugmenterTest { @Mock private ConfigUtil configUtil; - @Mock - private MzsDeliveryRequestValidator validator; - private Marshaller mzsMarshaller = new Marshaller(true); @Before @@ -110,11 +107,11 @@ public class DeliveryRequestAugmenterTest { } private DeliveryRequestAugmenter createAugmenter(ConfigType fallback) { - return new DeliveryRequestAugmenter(Map.of("default", fallback), configUtil, validator, mzsMarshaller); + return new DeliveryRequestAugmenter(Map.of("default", fallback), configUtil, mzsMarshaller); } private DeliveryRequestAugmenter createAugmenter(Map<String, ConfigType> profiles) { - return new DeliveryRequestAugmenter(profiles, configUtil, validator, mzsMarshaller); + return new DeliveryRequestAugmenter(profiles, configUtil, mzsMarshaller); } private ConfigType createConfig(String url, Boolean performTnvz) { |