Refactor MsgResponse and its IDs

StoreSOAPBodyBinaryInRepositoryInterceptor:
- Replace "generate body's id via concatenation" with "give the right
  generator function the app delivery id and let the generator
  function do the work". Reason: Prevent the logistics of deriving IDs
  to spill into unrelated components.

MsgResponse refactor:
- Make MsgResponse an abstract class.
- Derive ResponseID's  ONLY in MsgResponse::createResponseID.

Others:
- Ensure that all invocations to DeliveryRepository.getResponse and
  BinaryRepository.get use "responseID" instead of ambiguous "id" or
  incorrect "appDeliveryID".
- Move SingleThreadedDeliveryPipeline into process package.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/main/java/at/gv/egiz/moazs/verify/MsgResponseVerifier.java b/src/main/java/at/gv/egiz/moazs/verify/MsgResponseVerifier.java
index c5e04d9..6b4ef7a 100644
--- a/src/main/java/at/gv/egiz/moazs/verify/MsgResponseVerifier.java
+++ b/src/main/java/at/gv/egiz/moazs/verify/MsgResponseVerifier.java
@@ -33,12 +33,12 @@ public class MsgResponseVerifier {
         this.verifier = verifier;
     }
 
-    public MsgResponse verify(String id) {
+    public MsgResponse verify(String responseID) {
 
-        var response = repo.getResponse(id).get();
+        var response = repo.getResponse(responseID).get();
         var builder = moaZSExceptionBuilder().withAllParametersInAnswer(response.getAnswer());
 
-        var binaryResponse = binaryRepo.get(id).get();
+        var binaryResponse = binaryRepo.get(responseID).get();
 
         try {
             verifier.verify(binaryResponse);