Put MoaZSException on Diet & Handle Edge Cases

Reason: MoaZSException (and: its builder) were used to collect
intermediary results while stepping through the delivery request
backend. These results were needed to generate meaningful responses
towards the sender application in case of error. However, the builder
sprawled over too many interfaces (e.g. DeliveryRequestBackend and
TNVZHelper) and it became difficult to understand from where
intermediary results originated.

Solution: Put MoaZSException on diet:
- Remove all DeliveryAnswer fields from MoaZSException and refactor
  code base to ensure that the removed fields get sourced by other
  means.
- Remove Builder since amount of parameters is manageable.

Refactor DeliveryRequestBackend:
- Instead of passing down the builder and using MoaZSException as the
  only source for intermediary results, we collect available results
  at the outermost stack frame (DeliveryRequestBackend.accept) and
  only retrieve results via exception if those results appear
  somewhere down the stack frame (E.g. PredviceNoteSent). We collect
  available results with the "fallbackAnswerBuilder" and switch to the
  msg client response, once received.

Refactor MsgResponseBackend:
- Handle cases (response missing, binary response missing) properly.
- Integrate changes from MsgResponse.generateError()

Refactor TVNZHelper:
- Remove MoaZSExceptionBuilder from all interfaces.

Refactor MsgResponse.generateError:
- Change interface such that it's more intuitive.
- Implement NotificationResponse.generateError.
- Implement RequestStatusResponse.generateError.

Others:
- Replace all invocations against MoaZSException.Builder.

1 files changed, 8 insertions, 6 deletions

diff --git a/src/main/java/at/gv/egiz/moazs/service/MzsService.java b/src/main/java/at/gv/egiz/moazs/service/MzsService.java
index cbc56e4..8f0ef86 100644
--- a/src/main/java/at/gv/egiz/moazs/service/MzsService.java
+++ b/src/main/java/at/gv/egiz/moazs/service/MzsService.java
@@ -20,8 +20,8 @@ import java.util.concurrent.TimeoutException;
 import java.util.function.Consumer;
 
 import static at.gv.egiz.moazs.MoaZSException.moaZSException;
-import static at.gv.egiz.moazs.MoaZSException.moaZSExceptionBuilder;
 import static at.gv.zustellung.app2mzs.xsd.PartialSuccessType.partialSuccessTypeBuilder;
+import static java.lang.String.format;
 import static java.util.concurrent.CompletableFuture.supplyAsync;
 
 //todo : validate Schema in both directions.
@@ -33,6 +33,9 @@ public class MzsService implements App2MzsPortType {
 
     //TODO move timeout and namespaces to config
     private static final int TIMEOUT_FOR_ANWSER = 10;
+    private static final String MZS_SERVICE_ERROR_MSG = "An error occurred while processing DeliveryRequest " +
+            "with AppDeliveryID=%s.";
+    private static final String RESPONSE_MISSING_ERROR_MSG = "Could not get a response for AppDeliveryID=%s.";
 
     private final DeliveryRepository repository;
     private final Consumer<String> backend;
@@ -71,10 +74,8 @@ public class MzsService implements App2MzsPortType {
             return generatePartialSuccessResponse(appDeliveryID);
 
         } catch (Exception e) {
-            throw moaZSExceptionBuilder("An error occurred while processing DeliveryRequest " +
-                    "with AppDeliveryID=%s.", appDeliveryID)
-                    .withCause(e)
-                    .build();
+            var message = format(MZS_SERVICE_ERROR_MSG, appDeliveryID);
+            throw moaZSException(message, e);
         }
 
     }
@@ -82,6 +83,7 @@ public class MzsService implements App2MzsPortType {
     private DeliveryRequestStatusType process(DeliveryRequestType deliveryRequest) {
 
         var appDeliveryID = deliveryRequest.getMetaData().getAppDeliveryID();
+        //TODO: fix too.
         logger.info("Receive request with appDeliveryID = {}.", appDeliveryID);
 
         repository.store(deliveryRequest);
@@ -89,7 +91,7 @@ public class MzsService implements App2MzsPortType {
 
         var statusId = RequestStatusResponse.getResponseID(appDeliveryID);
         var response = repository.retrieveResponse(statusId)
-                .orElseThrow(() -> moaZSException("Could not get a response for AppDeliveryID=%s.", appDeliveryID));
+                .orElseThrow(() -> moaZSException(format(RESPONSE_MISSING_ERROR_MSG, appDeliveryID)));
         return (DeliveryRequestStatusType) response.getResponse();
     }