Refactor MsgResponse and its IDs

StoreSOAPBodyBinaryInRepositoryInterceptor:
- Replace "generate body's id via concatenation" with "give the right
  generator function the app delivery id and let the generator
  function do the work". Reason: Prevent the logistics of deriving IDs
  to spill into unrelated components.

MsgResponse refactor:
- Make MsgResponse an abstract class.
- Derive ResponseID's  ONLY in MsgResponse::createResponseID.

Others:
- Ensure that all invocations to DeliveryRepository.getResponse and
  BinaryRepository.get use "responseID" instead of ambiguous "id" or
  incorrect "appDeliveryID".
- Move SingleThreadedDeliveryPipeline into process package.

1 files changed, 21 insertions, 8 deletions

diff --git a/src/main/java/at/gv/egiz/moazs/scheme/MsgResponse.java b/src/main/java/at/gv/egiz/moazs/scheme/MsgResponse.java
index fe46451..699819f 100644
--- a/src/main/java/at/gv/egiz/moazs/scheme/MsgResponse.java
+++ b/src/main/java/at/gv/egiz/moazs/scheme/MsgResponse.java
@@ -3,13 +3,26 @@ package at.gv.egiz.moazs.scheme;
 import at.gv.egiz.moazs.MoaZSException;
 import at.gv.zustellung.msg.xsd.DeliveryAnswerType;
 
-public interface MsgResponse <T> {
-
-    String getResponseID();
-    T getResponse();
-    String getAppDeliveryID();
-    String getZSDeliveryID();
-    DeliveryAnswerType getAnswer();
-    MsgResponse<T> generateError(MoaZSException exception);
+public abstract class MsgResponse <T> {
+
+    protected String id;
+
+    protected MsgResponse(){
+        this.id = "";
+    }
+
+    public static String createResponseId(String appDeliveryID, String idSuffix) {
+        return appDeliveryID + idSuffix;
+    }
+
+    public String getResponseID() {
+        return id;
+    }
+
+    abstract public T getResponse();
+    abstract public String getAppDeliveryID();
+    abstract public String getZSDeliveryID();
+    abstract public DeliveryAnswerType getAnswer();
+    abstract public MsgResponse<T> generateError(MoaZSException exception);
 
 }