diff options
author | Christof Rabensteiner <christof.rabensteiner@iaik.tugraz.at> | 2019-07-09 11:13:35 +0200 |
---|---|---|
committer | Christof Rabensteiner <christof.rabensteiner@iaik.tugraz.at> | 2019-07-09 11:13:35 +0200 |
commit | 8e36fa01ea42d282eacdc78d6749daf9ae1ede9c (patch) | |
tree | ee691b4ec4a522c0b35c8251d3422702b90d2073 /src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java | |
parent | d8c668bbca31a835c387a3d52293c9938c424f58 (diff) | |
download | moa-zs-8e36fa01ea42d282eacdc78d6749daf9ae1ede9c.tar.gz moa-zs-8e36fa01ea42d282eacdc78d6749daf9ae1ede9c.tar.bz2 moa-zs-8e36fa01ea42d282eacdc78d6749daf9ae1ede9c.zip |
Refactor: Merge BinaryRepository into DeliveryRepository
- Reason: Components, which rely on one of those, usually also rely on
the other, so merging them reduces amount of dependencies.
- Frame operations in DeliveryRepository API as "store" and "retrieve"
operations.
- Rename: Convert *Id in local variable names to upper case.
Diffstat (limited to 'src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java')
-rw-r--r-- | src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java b/src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java index 7ccd236..68e96d9 100644 --- a/src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java +++ b/src/main/java/at/gv/egiz/moazs/repository/RedisDeliveryRepository.java @@ -3,8 +3,6 @@ package at.gv.egiz.moazs.repository; import at.gv.egiz.moazs.scheme.Marshaller; import at.gv.egiz.moazs.scheme.MsgResponse; import at.gv.zustellung.app2mzs.xsd.DeliveryRequestType; -import at.gv.zustellung.msg.xsd.DeliveryNotificationType; -import at.gv.zustellung.msg.xsd.DeliveryRequestStatusType; import at.gv.zustellung.app2mzs.xsd.ObjectFactory; import org.apache.tools.ant.filters.StringInputStream; import org.slf4j.Logger; @@ -42,7 +40,7 @@ public class RedisDeliveryRepository implements DeliveryRepository { } @Override - public void add(DeliveryRequestType request) { + public void store(DeliveryRequestType request) { var hashKey = request.getMetaData().getAppDeliveryID(); var serializedRequest = marshaller.marshallXml(factory.createDeliveryRequest(request)); @@ -51,7 +49,7 @@ public class RedisDeliveryRepository implements DeliveryRepository { } @Override - public Optional<DeliveryRequestType> getDeliveryRequest(String appDeliveryID) { + public Optional<DeliveryRequestType> retrieveDeliveryRequest(String appDeliveryID) { String serializedRequest = hashOperations.get(KEY, appDeliveryID); if (serializedRequest == null) { @@ -64,14 +62,24 @@ public class RedisDeliveryRepository implements DeliveryRepository { } @Override - public void add(MsgResponse notification) { + public void store(MsgResponse notification) { throw new UnsupportedOperationException(NOT_IMPLEMENTED_MESSAGE); } @Override - public Optional<MsgResponse> getResponse(String id) { + public Optional<MsgResponse> retrieveResponse(String id) { throw new UnsupportedOperationException(NOT_IMPLEMENTED_MESSAGE); } + @Override + public void store(String responseID, byte[] data) { + + } + + @Override + public Optional<byte[]> retrieveBinaryResponse(String responseID) { + return Optional.empty(); + } + } |