Refactor MsgResponse and its IDs

StoreSOAPBodyBinaryInRepositoryInterceptor:
- Replace "generate body's id via concatenation" with "give the right
  generator function the app delivery id and let the generator
  function do the work". Reason: Prevent the logistics of deriving IDs
  to spill into unrelated components.

MsgResponse refactor:
- Make MsgResponse an abstract class.
- Derive ResponseID's  ONLY in MsgResponse::createResponseID.

Others:
- Ensure that all invocations to DeliveryRepository.getResponse and
  BinaryRepository.get use "responseID" instead of ambiguous "id" or
  incorrect "appDeliveryID".
- Move SingleThreadedDeliveryPipeline into process package.

1 files changed, 2 insertions, 3 deletions

diff --git a/src/main/java/at/gv/egiz/moazs/repository/InMemoryDeliveryRepository.java b/src/main/java/at/gv/egiz/moazs/repository/InMemoryDeliveryRepository.java
index d9abb7b..3b5a020 100644
--- a/src/main/java/at/gv/egiz/moazs/repository/InMemoryDeliveryRepository.java
+++ b/src/main/java/at/gv/egiz/moazs/repository/InMemoryDeliveryRepository.java
@@ -39,12 +39,11 @@ public class InMemoryDeliveryRepository implements DeliveryRepository {
     @Override
     public void add(MsgResponse response) {
         String key = response.getResponseID();
-        System.out.println("storing with response id " + key);
         responseRepository.put(key, response);
     }
 
     @Override
-    public Optional<MsgResponse> getResponse(String id) {
-        return ofNullable(responseRepository.getIfPresent(id));
+    public Optional<MsgResponse> getResponse(String responseID) {
+        return ofNullable(responseRepository.getIfPresent(responseID));
     }
 }