1 files changed, 51 insertions, 62 deletions

diff --git a/moaSig/moa-sig-lib/src/main/java/at/gv/egovernment/moa/spss/api/xmlbind/CreateCMSSignatureResponseBuilder.java b/moaSig/moa-sig-lib/src/main/java/at/gv/egovernment/moa/spss/api/xmlbind/CreateCMSSignatureResponseBuilder.java
index 7ce0871..12b408b 100644
--- a/moaSig/moa-sig-lib/src/main/java/at/gv/egovernment/moa/spss/api/xmlbind/CreateCMSSignatureResponseBuilder.java
+++ b/moaSig/moa-sig-lib/src/main/java/at/gv/egovernment/moa/spss/api/xmlbind/CreateCMSSignatureResponseBuilder.java
@@ -21,14 +21,10 @@
  * that you distribute must include a readable copy of the "NOTICE" text file.
  */
 
-
 package at.gv.egovernment.moa.spss.api.xmlbind;
 
-import java.io.IOException;
 import java.util.Iterator;
 
-import javax.xml.transform.TransformerException;
-
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 
@@ -37,76 +33,71 @@ import at.gv.egovernment.moa.spss.api.cmssign.CMSSignatureResponse;
 import at.gv.egovernment.moa.spss.api.cmssign.CreateCMSSignatureResponse;
 import at.gv.egovernment.moa.spss.api.cmssign.CreateCMSSignatureResponseElement;
 import at.gv.egovernment.moa.spss.api.xmlsign.ErrorResponse;
-import at.gv.egovernment.moa.spss.api.xmlsign.SignatureEnvironmentResponse;
 import at.gv.egovernment.moaspss.util.Constants;
-import at.gv.egovernment.moaspss.util.DOMUtils;
 
 /**
- * Convert a <code>CreateCMSSignatureResponse</code> API object into its
- * XML representation, according to the MOA XML schema.
- * 
+ * Convert a <code>CreateCMSSignatureResponse</code> API object into its XML
+ * representation, according to the MOA XML schema.
+ *
  * @version $Id$
  */
 public class CreateCMSSignatureResponseBuilder {
   private static final String MOA_NS_URI = Constants.MOA_NS_URI;
 
   /** The XML document containing the response element. */
-  private Document responseDoc;
+  private final Document responseDoc;
   /** The response <code>CreateCMSSignatureResponse</code> DOM element. */
-  private Element responseElem;
+  private final Element responseElem;
 
   /**
    * Create a new <code>CreateCMSSignatureResponseBuilder</code>:
-   * 
-   * @throws MOASystemException An error occurred setting up the resulting
-   * XML document.
+   *
+   * @throws MOASystemException An error occurred setting up the resulting XML
+   *                            document.
    */
   public CreateCMSSignatureResponseBuilder() throws MOASystemException {
     responseDoc =
-      ResponseBuilderUtils.createResponse("CreateCMSSignatureResponse");
+        ResponseBuilderUtils.createResponse("CreateCMSSignatureResponse");
     responseElem = responseDoc.getDocumentElement();
   }
 
   /**
-   * Build a document containing a <code>CreateCMSSignatureResponse</code>
-   * DOM element being the XML representation of the given 
+   * Build a document containing a <code>CreateCMSSignatureResponse</code> DOM
+   * element being the XML representation of the given
    * <code>CreateCMSSignatureResponse</code> API object.
-   * 
-   * @param response The <code>CreateCMSSignatureResponse</code> to convert
-   * to XML.
-   * @return A document containing the <code>CreateCMSSignatureResponse</code>
-   * DOM element.
+   *
+   * @param response The <code>CreateCMSSignatureResponse</code> to convert to
+   *                 XML.
+   * @return A document containing the <code>CreateCMSSignatureResponse</code> DOM
+   *         element.
    */
   public Document build(CreateCMSSignatureResponse response) {
     Iterator iter;
 
-    
-     
-    
     for (iter = response.getResponseElements().iterator(); iter.hasNext();) {
-      
-    	Object responseObj = iter.next();
-    	
-    	if (responseObj instanceof ErrorResponse) {
-    		ErrorResponse errorResponse = (ErrorResponse) responseObj;
-            addErrorResponse(errorResponse);
-    		
-    	} else if (responseObj instanceof CreateCMSSignatureResponseElement) {
-    		CMSSignatureResponse cmsSignatureResponse = (CMSSignatureResponse) responseObj;
-        	addCMSSignature(cmsSignatureResponse);
-    		
-    	}
-    	
+
+      final Object responseObj = iter.next();
+
+      if (responseObj instanceof ErrorResponse) {
+        final ErrorResponse errorResponse = (ErrorResponse) responseObj;
+        addErrorResponse(errorResponse);
+
+      } else if (responseObj instanceof CreateCMSSignatureResponseElement) {
+        final CMSSignatureResponse cmsSignatureResponse = (CMSSignatureResponse) responseObj;
+        addCMSSignature(cmsSignatureResponse);
+
+      }
+
 //    	CreateCMSSignatureResponseElement responseElement =
 //        (CreateCMSSignatureResponseElement) iter.next();
-//      
+//
 //      switch (responseElement.getResponseType()) {
 //        case CreateCMSSignatureResponseElement.CMS_SIGNATURE :
-//        	
+//
 //          break;
 //
 //        case CreateCMSSignatureResponseElement.ERROR_RESPONSE :
-//          
+//
 //          break;
 //      }
 
@@ -115,37 +106,35 @@ public class CreateCMSSignatureResponseBuilder {
     return responseDoc;
   }
 
-
-
   /**
    * Add a <code>CMSSignature</code> element to the response.
-   * 
+   *
    * @param cmsSignatureResponse The content to put under the
-   * <code>CMSSignature</code> element.
+   *                             <code>CMSSignature</code> element.
    */
   private void addCMSSignature(CMSSignatureResponse cmsSignatureResponse) {
-	  String base64Value = cmsSignatureResponse.getCMSSignature();
-	  
-	  Element cmsSignature = responseDoc.createElementNS(MOA_NS_URI, "CMSSignature");	  
-	  cmsSignature.setTextContent(base64Value);
-	  
-	  responseElem.appendChild(cmsSignature);
-	  
-}
-  
+    final String base64Value = cmsSignatureResponse.getCMSSignature();
+
+    final Element cmsSignature = responseDoc.createElementNS(MOA_NS_URI, "CMSSignature");
+    cmsSignature.setTextContent(base64Value);
+
+    responseElem.appendChild(cmsSignature);
+
+  }
+
   /**
    * Add a <code>ErrorResponse</code> element to the response.
-   *  
+   * 
    * @param errorResponse The API object containing the information to put into
-   * the <code>ErrorResponse</code> DOM element.
+   *                      the <code>ErrorResponse</code> DOM element.
    */
   private void addErrorResponse(ErrorResponse errorResponse) {
-    Element errorElem =
-      responseDoc.createElementNS(MOA_NS_URI, "ErrorResponse");
-    Element errorCodeElem =
-      responseDoc.createElementNS(MOA_NS_URI, "ErrorCode");
-    Element infoElem = responseDoc.createElementNS(MOA_NS_URI, "Info");
-    String errorCodeStr = Integer.toString(errorResponse.getErrorCode());
+    final Element errorElem =
+        responseDoc.createElementNS(MOA_NS_URI, "ErrorResponse");
+    final Element errorCodeElem =
+        responseDoc.createElementNS(MOA_NS_URI, "ErrorCode");
+    final Element infoElem = responseDoc.createElementNS(MOA_NS_URI, "Info");
+    final String errorCodeStr = Integer.toString(errorResponse.getErrorCode());
 
     errorCodeElem.appendChild(responseDoc.createTextNode(errorCodeStr));
     errorElem.appendChild(errorCodeElem);