1 files changed, 19 insertions, 14 deletions
diff --git a/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/InitialSearchTask.java b/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/InitialSearchTask.java
index 1563d6df..01497f8d 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/InitialSearchTask.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/InitialSearchTask.java
@@ -42,6 +42,8 @@ import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.Constants;
+import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.MatchedPersonResult;
+import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.RegisterResult;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.SimpleEidasData;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.exception.EidPostProcessingException;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.exception.EidasAttributeException;
@@ -71,9 +73,9 @@ import lombok.extern.slf4j.Slf4j;
  * Output:
  * <ul>
  *     <li>{@link Constants#DATA_SIMPLE_EIDAS} converted from Full eIDAS Response</li>
- *     <li>{@link Constants#DATA_INITIAL_REGISTER_RESULT} results from first search in registers with
+ *     <li>{@link Constants#DATA_INTERMEDIATE_RESULT} results from first search in registers with
  *     PersonIdentifier</li>
- *     <li>{@link Constants#DATA_FURTHER_REGISTER_RESULT} results after second search in registers with MDS</li>
+ *     <li>{@link Constants#DATA_PERSON_MATCH_RESULT} results after second search in registers with MDS</li>
  *     <li>{@link Constants#DATA_RESULT_MATCHING_BPK} if one register result found</li>
  * </ul>
  * Transitions:
@@ -135,8 +137,7 @@ public class InitialSearchTask extends AbstractAuthServletTask {
         step6CountrySpecificSearch(executionContext, initialSearchResult.getOperationStatus(), eidasData);
       
       } else if (resultCount == 1) {      
-        // find person by PersonalIdentifier --> finalize first matching task             
-        initialSearchResult.setMatchingFinished(true);                
+        // find person by PersonalIdentifier --> finalize first matching task
         foundMatchFinializeTask(initialSearchResult, eidasData);
             
       } else {
@@ -169,8 +170,7 @@ public class InitialSearchTask extends AbstractAuthServletTask {
       log.trace("'step6CountrySpecificSearch' finds a person. Forward to 'step7aKittProcess' step ... ");
       registerSearchService.step7aKittProcess(countrySpecificResult, eidasData);
       
-      // find person by country-specific information --> finalize first matching task
-      countrySpecificResult.setMatchingFinished(true);        
+      // find person by country-specific information --> finalize first matching task       
       foundMatchFinializeTask(countrySpecificResult, eidasData);      
       
     } else {
@@ -194,7 +194,7 @@ public class InitialSearchTask extends AbstractAuthServletTask {
       log.debug("Matching step: 'step8RegisterSearchWithMds' has #{} results. "
           + "Forward to GUI based matching steps ... ", registerData.getResultCount());
       
-      MatchingTaskUtils.storeInitialRegisterResult(pendingReq, registerData);
+      MatchingTaskUtils.storeIntermediateMatchingResult(pendingReq, registerData);
       executionContext.put(TRANSITION_TO_GENERATE_OTHER_LOGIN_METHOD_GUI_TASK, true);
       
     }
@@ -205,22 +205,26 @@ public class InitialSearchTask extends AbstractAuthServletTask {
   private void foundMatchFinializeTask(RegisterSearchResult searchResult, SimpleEidasData eidasData) 
       throws WorkflowException, EaafStorageException {
     // check if register update is required
-    step3CheckRegisterUpdateNecessary(searchResult, eidasData);
-    
+    RegisterResult updatedResult = step3CheckRegisterUpdateNecessary(searchResult.getResult(), eidasData);
+        
     // store search result
-    MatchingTaskUtils.storeInitialRegisterResult(pendingReq, searchResult);
+    MatchingTaskUtils.storeFinalMatchingResult(pendingReq, 
+        MatchedPersonResult.generateFormMatchingResult(updatedResult, eidasData.getCitizenCountryCode()));
         
   }
   
-  private void step3CheckRegisterUpdateNecessary(RegisterSearchResult initialSearchResult, 
+  private RegisterResult step3CheckRegisterUpdateNecessary(RegisterResult searchResult, 
       SimpleEidasData eidasData) throws WorkflowException {
     log.trace("Starting step3CheckRegisterUpdateNecessary");
-    if (!eidasData.equalsRegisterData(initialSearchResult)) {
-      // TODO Update "initialSearchResult" in register with "eidasData" from login not possible for now
+    if (!eidasData.equalsRegisterData(searchResult)) {
       log.info("Skipping update-register-information step, because it's not supported yet");
+      
+      //TODO: return updated search result if updates are allowed
+      return searchResult;
         
     } else {        
-      log.debug("Register information match to eIDAS information. No update requird");      
+      log.debug("Register information match to eIDAS information. No update requird");
+      return searchResult;
       
     }
     
@@ -233,6 +237,7 @@ public class InitialSearchTask extends AbstractAuthServletTask {
         .getGenericDataFromSession(Constants.DATA_FULL_EIDAS_RESPONSE, ILightResponse.class);
     Map<String, Object> simpleMap = convertEidasAttrToSimpleMap(eidasResponse.getAttributes().getAttributeMap());
     return eidPostProcessor.postProcess(simpleMap);
+    
   }
 
   private Map<String, Object> convertEidasAttrToSimpleMap(