Replace ErnpEidData with SimpleEidasData

3 files changed, 27 insertions, 36 deletions

diff --git a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTest.java b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTest.java
index d8f2e47f..d861006e 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTest.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTest.java
@@ -25,7 +25,7 @@ package at.asitplus.eidas.specific.modules.auth.eidas.v2.test;
 
 import at.asitplus.eidas.specific.connector.test.config.dummy.MsConnectorDummyConfigMap;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.Constants;
-import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.ErnpEidData;
+import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.SimpleEidasData;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.exception.EidasSAuthenticationException;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.exception.SzrCommunicationException;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.szr.SzrClient;
@@ -39,7 +39,6 @@ import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.RandomStringUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.cxf.binding.soap.SoapFault;
-import org.joda.time.DateTime;
 import org.junit.*;
 import org.junit.runner.RunWith;
 import org.slf4j.Logger;
@@ -341,11 +340,11 @@ public class SzrClientTest {
 
   }
 
-  private ErnpEidData getEidData() {
-    return ErnpEidData.builder()
+  private SimpleEidasData getEidData() {
+    return SimpleEidasData.builder()
         .familyName("Mustermann")
         .givenName("Franz")
-        .dateOfBirth(new DateTime(1989,5,5,1,1))
+        .dateOfBirth("1989-05-05")
         .citizenCountryCode("IS")
         .pseudonym("1234sdgsdfg56789ABCDEF")
         .build();
diff --git a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTestProduction.java b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTestProduction.java
index 33d72a59..e50044c6 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTestProduction.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/SzrClientTestProduction.java
@@ -24,7 +24,7 @@
 package at.asitplus.eidas.specific.modules.auth.eidas.v2.test;
 
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.Constants;
-import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.ErnpEidData;
+import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.SimpleEidasData;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.exception.EidasSAuthenticationException;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.exception.SzrCommunicationException;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.szr.SzrClient;
@@ -36,7 +36,6 @@ import at.gv.egiz.eaaf.core.impl.idp.auth.data.SimpleIdentityLinkAssertionParser
 import org.apache.commons.lang3.RandomStringUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.bouncycastle.util.encoders.Base64;
-import org.joda.time.DateTime;
 import org.junit.Assert;
 import org.junit.Ignore;
 import org.junit.Test;
@@ -161,11 +160,11 @@ public class SzrClientTestProduction {
 
   }
 
-  private ErnpEidData getEidData() {
-    return ErnpEidData.builder()
+  private SimpleEidasData getEidData() {
+    return SimpleEidasData.builder()
         .familyName("Mustermann")
         .givenName("Franz")
-        .dateOfBirth(new DateTime(1989,5,4,1,1))
+        .dateOfBirth("1989-05-04")
         .citizenCountryCode("IS")
         .pseudonym("1234ffgsdfg56789ABCDEF")
         .build();
diff --git a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/validation/EidasAttributePostProcessingTest.java b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/validation/EidasAttributePostProcessingTest.java
index 381406d2..0a4ab851 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/validation/EidasAttributePostProcessingTest.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/validation/EidasAttributePostProcessingTest.java
@@ -30,7 +30,7 @@ import java.text.SimpleDateFormat;
 import java.util.HashMap;
 import java.util.Map;
 
-import org.joda.time.DateTime;
+import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.SimpleEidasData;
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -41,7 +41,6 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
 
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.Constants;
-import at.asitplus.eidas.specific.modules.auth.eidas.v2.dao.ErnpEidData;
 import at.asitplus.eidas.specific.modules.auth.eidas.v2.service.CcSpecificEidProcessingService;
 
 @RunWith(SpringJUnit4ClassRunner.class)
@@ -59,7 +58,7 @@ public class EidasAttributePostProcessingTest {
       "DE/AT/532eaabd9574880dbf76b9b8cc00832c20a6ec113d682299550d7a6e0f345e25";
   private static final String P1_GIVENNAME = "Max";
   private static final String P1_FAMILYNAME = "Mustermann";
-  private static final DateTime P1_DATEOFBIRTH = DateTime.now();
+  private static final String P1_DATEOFBIRTH = "2020-01-04";
   private static final String P1_PLACEOFBIRTH = "Nirgendwo";
   private static final String P1_BIRTHNAME = "Musterkind";
 
@@ -68,7 +67,7 @@ public class EidasAttributePostProcessingTest {
       "DE/AT/532eaabd9574880dbf76b9b8cc00832c20A6ec113d682299550d7a6e0f345e25";
   private static final String P3_GIVENNAME = "Max";
   private static final String P3_FAMILYNAME = "Mustermann";
-  private static final DateTime P3_DATEOFBIRTH = DateTime.now();
+  private static final String P3_DATEOFBIRTH = "2020-01-03";
   private static final String P3_PLACEOFBIRTH = "Nirgendwo";
   private static final String P3_BIRTHNAME = "Musterkind";
 
@@ -77,7 +76,7 @@ public class EidasAttributePostProcessingTest {
       "DE/AT/532EAABD9574880DBF76B9B8CC00832C20A6EC113D682299550D7A6E0F345E25";
   private static final String P4_GIVENNAME = "Max";
   private static final String P4_FAMILYNAME = "Mustermann";
-  private static final DateTime P4_DATEOFBIRTH = DateTime.now();
+  private static final String P4_DATEOFBIRTH = "2020-01-05";
   private static final String P4_PLACEOFBIRTH = "Nirgendwo";
   private static final String P4_BIRTHNAME = "Musterkind";
 
@@ -86,7 +85,7 @@ public class EidasAttributePostProcessingTest {
       "DE/AT/532EAABD9574880DBF76B9B8CC00832C20A6EC113D682299550D7A6E0F345E251";
   private static final String P5_GIVENNAME = "Max";
   private static final String P5_FAMILYNAME = "Mustermann";
-  private static final DateTime P5_DATEOFBIRTH = DateTime.now();
+  private static final String P5_DATEOFBIRTH = "2020-01-06";
   private static final String P5_PLACEOFBIRTH = "Nirgendwo";
   private static final String P5_BIRTHNAME = "Musterkind";
 
@@ -94,7 +93,7 @@ public class EidasAttributePostProcessingTest {
   private static final String P6_eIDASID = "DE/AT/532EAABD9574880DBF76B9B8CC00832C20A6EC113D682299550D7A6E0F";
   private static final String P6_GIVENNAME = "Max";
   private static final String P6_FAMILYNAME = "Mustermann";
-  private static final DateTime P6_DATEOFBIRTH = DateTime.now();
+  private static final String P6_DATEOFBIRTH = "2020-01-08";
   private static final String P6_PLACEOFBIRTH = "Nirgendwo";
   private static final String P6_BIRTHNAME = "Musterkind";
 
@@ -102,7 +101,7 @@ public class EidasAttributePostProcessingTest {
   private static final String P7_eIDASID = "DE/AT/532EAABD9574880DBF76B9B8CC00832C20A6EC113D682299550D7A6E0F";
   private static final String P7_GIVENNAME = "Max";
   private static final String P7_FAMILYNAME = "Mustermann";
-  private static final DateTime P7_DATEOFBIRTH = DateTime.now();
+  private static final String P7_DATEOFBIRTH = "2020-01-09";
   private static final String P7_PLACEOFBIRTH = "Nirgendwo";
   private static final String P7_BIRTHNAME = "Musterkind";
 
@@ -110,7 +109,7 @@ public class EidasAttributePostProcessingTest {
       "EE/AT/asfasfasdfasdfasdfasdfasdfasvafasdfasdfasdfasdfasdfasvascasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
   private static final String P2_GIVENNAME = "Max";
   private static final String P2_FAMILYNAME = "Mustermann";
-  private static final DateTime P2_DATEOFBIRTH = DateTime.now();
+  private static final String P2_DATEOFBIRTH = "2020-01-10";
   private static final String P2_PLACEOFBIRTH = "Nirgendwo";
   private static final String P2_BIRTHNAME = "Musterkind";
 
@@ -129,7 +128,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void deWithHexLowerCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P1_eIDASID,
               P1_FAMILYNAME,
@@ -156,7 +155,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void deWithHexMixedCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P3_eIDASID,
               P3_FAMILYNAME,
@@ -183,7 +182,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void deWithHexUpperCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P4_eIDASID,
               P4_FAMILYNAME,
@@ -270,7 +269,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void eeTestCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P2_eIDASID,
               P2_FAMILYNAME,
@@ -297,7 +296,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void eeTestFamilyNameMissingCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P2_eIDASID,
               null,
@@ -326,7 +325,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void eeTestGivenNameMissingCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P2_eIDASID,
               P2_FAMILYNAME,
@@ -355,7 +354,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void eeTestDateOfBirthMissingCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               P2_eIDASID,
               P2_FAMILYNAME,
@@ -384,7 +383,7 @@ public class EidasAttributePostProcessingTest {
   @Test
   public void eeTestIdMissingCase() throws Exception {
     try {
-      final ErnpEidData result = postProcessor.postProcess(
+      final SimpleEidasData result = postProcessor.postProcess(
           generateInputData(
               null,
               P2_FAMILYNAME,
@@ -411,7 +410,7 @@ public class EidasAttributePostProcessingTest {
   }
 
   private Map<String, Object> generateInputData(String id, String familyName, String givenName,
-      DateTime dateOfBirth, String placeOfBirth, String birthName) {
+                                                String dateOfBirth, String placeOfBirth, String birthName) {
     final Map<String, Object> result = new HashMap<>();
     result.put(Constants.eIDAS_ATTR_PERSONALIDENTIFIER, id);
     result.put(Constants.eIDAS_ATTR_CURRENTGIVENNAME, givenName);
@@ -423,8 +422,8 @@ public class EidasAttributePostProcessingTest {
 
   }
 
-  private void validate(ErnpEidData result, String id, String familyName, String givenName,
-                        DateTime dateOfBirth, String placeOfBirth, String birthName) {
+  private void validate(SimpleEidasData result, String id, String familyName, String givenName,
+                        String dateOfBirth, String placeOfBirth, String birthName) {
     if (!result.getPseudonym().equals(id)) {
       fail(result.getPseudonym() + "is not equal to " + id);
     }
@@ -441,12 +440,6 @@ public class EidasAttributePostProcessingTest {
       fail(result.getDateOfBirth() + "is not equal to " + dateOfBirth);
     }
 
-    if (!result.getFormatedDateOfBirth().equals(new SimpleDateFormat("yyyy-MM-dd").format(dateOfBirth
-        .toDate()))) {
-      fail(result.getDateOfBirth() + "is not equal to " + new SimpleDateFormat("yyyy-MM-dd").format(
-          dateOfBirth.toDate()));
-    }
-
     if (!result.getPlaceOfBirth().equals(placeOfBirth)) {
       fail(result.getPlaceOfBirth() + "is not equal to " + placeOfBirth);
     }