to some more code quality tasks

1 files changed, 6 insertions, 7 deletions

diff --git a/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/impl/metadata/AbstractChainingMetadataProvider.java b/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/impl/metadata/AbstractChainingMetadataProvider.java
index ec81353a..8a6105bc 100644
--- a/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/impl/metadata/AbstractChainingMetadataProvider.java
+++ b/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/impl/metadata/AbstractChainingMetadataProvider.java
@@ -401,7 +401,7 @@ public abstract class AbstractChainingMetadataProvider extends SimpleMetadataPro
 
 
   protected void emitChangeEvent() {
-    if ((getObservers() == null) || (getObservers().size() == 0)) {
+    if (getObservers() == null || getObservers().size() == 0) {
       return;
     }
 
@@ -463,13 +463,12 @@ public abstract class AbstractChainingMetadataProvider extends SimpleMetadataPro
         while (metadataUrlInterator.hasNext()) {
           final String metadataurl = metadataUrlInterator.next();
           try {
-            if (StringUtils.isNotEmpty(metadataurl)) {
-              if (loadedproviders.containsKey(metadataurl)) {
-                // SAML2 SP is actually loaded, to nothing
-                providersinuse.put(metadataurl, loadedproviders.get(metadataurl));
-                loadedproviders.remove(metadataurl);
+            if (StringUtils.isNotEmpty(metadataurl)
+            	&& loadedproviders.containsKey(metadataurl)) {
+              // SAML2 SP is actually loaded, to nothing
+              providersinuse.put(metadataurl, loadedproviders.get(metadataurl));
+              loadedproviders.remove(metadataurl);
 
-              }
             }
           } catch (final Throwable e) {
             log.error("Failed to add Metadata (unhandled reason: " + e.getMessage(), e);