some code code-style modifications

active code-quality checks!

1 files changed, 23 insertions, 27 deletions

diff --git a/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/AbstractSL20AuthenticationModulImpl.java b/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/AbstractSL20AuthenticationModulImpl.java
index 1a88c43b..e9932ae8 100644
--- a/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/AbstractSL20AuthenticationModulImpl.java
+++ b/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/AbstractSL20AuthenticationModulImpl.java
@@ -2,19 +2,21 @@ package at.gv.egiz.eaaf.modules.auth.sl20;
 
 import java.util.Arrays;
 import java.util.List;
+
 import javax.annotation.PostConstruct;
+
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+
 import at.gv.egiz.eaaf.core.api.IRequest;
 import at.gv.egiz.eaaf.core.api.idp.IConfiguration;
-import at.gv.egiz.eaaf.core.api.idp.IspConfiguration;
+import at.gv.egiz.eaaf.core.api.idp.ISpConfiguration;
 import at.gv.egiz.eaaf.core.api.idp.auth.modules.AuthModule;
 import at.gv.egiz.eaaf.core.api.idp.process.ExecutionContext;
 import at.gv.egiz.eaaf.core.impl.idp.auth.AbstractAuthenticationManager;
 import at.gv.egiz.eaaf.modules.auth.sl20.utils.SL20Constants;
-import org.apache.commons.lang3.StringUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
-
 
 /**
  * AuthModule to select a Securtiy-Layer 2.0 based authentication process.
@@ -23,8 +25,7 @@ import org.springframework.beans.factory.annotation.Autowired;
  *
  */
 public abstract class AbstractSL20AuthenticationModulImpl implements AuthModule {
-  private static final Logger log =
-      LoggerFactory.getLogger(AbstractSL20AuthenticationModulImpl.class);
+  private static final Logger log = LoggerFactory.getLogger(AbstractSL20AuthenticationModulImpl.class);
 
   private int priority = 3;
   public static final List<String> VDA_TYPE_IDS = Arrays.asList("1", "2", "3", "4");
@@ -56,17 +57,15 @@ public abstract class AbstractSL20AuthenticationModulImpl implements AuthModule
 
   }
 
-
   /*
    * (non-Javadoc)
    *
-   * @see
-   * at.gv.egovernment.moa.id.auth.modules.AuthModule#selectProcess(at.gv.egovernment.moa.id.process
-   * .api.ExecutionContext)
+   * @see at.gv.egovernment.moa.id.auth.modules.AuthModule#selectProcess(at.gv.
+   * egovernment.moa.id.process .api.ExecutionContext)
    */
   @Override
   public String selectProcess(final ExecutionContext context, final IRequest pendingReq) {
-    final IspConfiguration spConfig = pendingReq.getServiceProviderConfiguration();
+    final ISpConfiguration spConfig = pendingReq.getServiceProviderConfiguration();
 
     if (spConfig == null) {
       log.error("Suspect state. NO SP CONFIGURATION IN CONTEXT!");
@@ -74,17 +73,13 @@ public abstract class AbstractSL20AuthenticationModulImpl implements AuthModule
 
     }
 
-    final String sl20ClientTypeHeader =
-        (String) context.get(SL20Constants.HTTP_HEADER_SL20_CLIENT_TYPE.toLowerCase());
-    final String sl20VdaTypeHeader =
-        (String) context.get(SL20Constants.HTTP_HEADER_SL20_VDA_TYPE.toLowerCase());
+    final String sl20ClientTypeHeader = (String) context.get(SL20Constants.HTTP_HEADER_SL20_CLIENT_TYPE.toLowerCase());
+    final String sl20VdaTypeHeader = (String) context.get(SL20Constants.HTTP_HEADER_SL20_VDA_TYPE.toLowerCase());
 
     if (authConfig.getBasicConfigurationBoolean(getGeneralConfigPropertyNameEnableModule(),
         getGeneralConfigPropertyNameEnableModuleDefault())) {
-      if (StringUtils
-              .isNotEmpty(spConfig.getConfigurationValue(getSpConfigPropertyNameEnableModule()))
-          && Boolean
-              .valueOf(spConfig.getConfigurationValue(getSpConfigPropertyNameEnableModule()))) {
+      if (StringUtils.isNotEmpty(spConfig.getConfigurationValue(getSpConfigPropertyNameEnableModule()))
+          && Boolean.valueOf(spConfig.getConfigurationValue(getSpConfigPropertyNameEnableModule()))) {
         log.debug("SL2.0 is enabled for " + spConfig.getUniqueIdentifier());
         log.trace(SL20Constants.HTTP_HEADER_SL20_CLIENT_TYPE + ": " + sl20ClientTypeHeader);
         log.trace(SL20Constants.HTTP_HEADER_SL20_VDA_TYPE + ": " + sl20VdaTypeHeader);
@@ -97,8 +92,7 @@ public abstract class AbstractSL20AuthenticationModulImpl implements AuthModule
       }
 
     } else {
-      log.trace("SL2.0 is NOT enabled with property: {}",
-          getGeneralConfigPropertyNameEnableModule());
+      log.trace("SL2.0 is NOT enabled with property: {}", getGeneralConfigPropertyNameEnableModule());
       return null;
 
     }
@@ -106,22 +100,24 @@ public abstract class AbstractSL20AuthenticationModulImpl implements AuthModule
   }
 
   /**
-   * Get the general configuration-key that holds the enabled key for this authentication module.
+   * Get the general configuration-key that holds the enabled key for this
+   * authentication module.
    *
    * @return
    */
   public abstract String getGeneralConfigPropertyNameEnableModule();
 
   /**
-   * Get the default value of the general configuration-key that holds the enabled key for this
-   * authentication module.
+   * Get the default value of the general configuration-key that holds the enabled
+   * key for this authentication module.
    *
    * @return
    */
   public abstract boolean getGeneralConfigPropertyNameEnableModuleDefault();
 
   /**
-   * Get the SP specific configuration-key that holds the enabled key for this authentication module.
+   * Get the SP specific configuration-key that holds the enabled key for this
+   * authentication module.
    *
    * @return configuration key for SP configuration
    */