to some more code quality tasks

1 files changed, 7 insertions, 11 deletions

diff --git a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/AbstractAuthenticationManager.java b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/AbstractAuthenticationManager.java
index 7a967d3f..241b43c9 100644
--- a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/AbstractAuthenticationManager.java
+++ b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/AbstractAuthenticationManager.java
@@ -161,12 +161,12 @@ public abstract class AbstractAuthenticationManager implements IAuthenticationMa
 
     // force new authentication authentication process
     if (pendingReq.forceAuth()) {
-      startAuthenticationProcess(httpReq, httpResp, (RequestImpl) pendingReq);
+      startAuthenticationProcess(httpReq, (RequestImpl) pendingReq);
       return false;
 
       // perform SSO-Consents evaluation if it it required
     } else if (isValidSsoSession && pendingReq.isNeedUserConsent()) {
-      sendSingleSignOnConsentsEvaluation(httpReq, httpResp, (RequestImpl) pendingReq);
+      sendSingleSignOnConsentsEvaluation((RequestImpl) pendingReq);
       return false;
 
 
@@ -193,7 +193,7 @@ public abstract class AbstractAuthenticationManager implements IAuthenticationMa
 
       } else {
         // Start authentication!
-        startAuthenticationProcess(httpReq, httpResp, (RequestImpl) pendingReq);
+        startAuthenticationProcess(httpReq, (RequestImpl) pendingReq);
         return false;
 
       }
@@ -230,14 +230,13 @@ public abstract class AbstractAuthenticationManager implements IAuthenticationMa
    * Populate process execution context and start process engine.
    *
    * @param httpReq http request
-   * @param httpResp http response
    * @param pendingReq current pending request
    * @throws ServletException In case of a servlet error
    * @throws IOException In case of an IO error
    * @throws EaafException In case of EAAF processing error
    */
   private void startAuthenticationProcess(final HttpServletRequest httpReq,
-      final HttpServletResponse httpResp, final RequestImpl pendingReq) throws EaafException {
+      final RequestImpl pendingReq) throws EaafException {
 
     log.info("Starting authentication ...");
     revisionsLogger.logEvent(pendingReq, EVENT_AUTHENTICATION_PROCESS_STARTED);
@@ -253,9 +252,9 @@ public abstract class AbstractAuthenticationManager implements IAuthenticationMa
     if (httpReq.getAttribute("javax.servlet.request.X509Certificate") != null) {
       log.debug("Find SSL-client-certificate on request --> Add it to context");
       executionContext.put(EAAFConstants.PROCESS_ENGINE_SSL_CLIENT_CERTIFICATE,
-          ((X509Certificate[]) httpReq.getAttribute("javax.servlet.request.X509Certificate")));
+          (X509Certificate[]) httpReq.getAttribute("javax.servlet.request.X509Certificate"));
       pendingReq.setRawDataToTransaction(EAAFConstants.PROCESS_ENGINE_SSL_CLIENT_CERTIFICATE,
-          (httpReq.getAttribute("javax.servlet.request.X509Certificate")));
+          httpReq.getAttribute("javax.servlet.request.X509Certificate"));
 
     }
 
@@ -313,15 +312,12 @@ public abstract class AbstractAuthenticationManager implements IAuthenticationMa
   /**
    * Starting a user consent evaluation.
    *
-   * @param request http request
-   * @param response http response
    * @param pendingReq current pending request
    * @throws ServletException In case of a servlet error
    * @throws IOException In case of an IO error
    * @throws EaafException In case of a EAAF processing error
    */
-  private void sendSingleSignOnConsentsEvaluation(final HttpServletRequest request,
-      final HttpServletResponse response, final RequestImpl pendingReq) throws EaafException {
+  private void sendSingleSignOnConsentsEvaluation(final RequestImpl pendingReq) throws EaafException {
 
     log.debug("Starting SSO user-consents evaluation ...");