summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Lenz <thomas.lenz@egiz.gv.at>2021-01-22 17:09:37 +0100
committerThomas Lenz <thomas.lenz@egiz.gv.at>2021-01-22 17:09:37 +0100
commit50a73b4cdb039d852aad5fb2c4722e15bb75477c (patch)
tree63df2f621ad4ca468cda2a492683429c868dc02a
parent0727e7447a08e63f500bcf0d4273c50c4b120f4e (diff)
downloadEAAF-Components-50a73b4cdb039d852aad5fb2c4722e15bb75477c.tar.gz
EAAF-Components-50a73b4cdb039d852aad5fb2c4722e15bb75477c.tar.bz2
EAAF-Components-50a73b4cdb039d852aad5fb2c4722e15bb75477c.zip
code-style and logging optimizations
-rw-r--r--eaaf_core_api/src/main/java/at/gv/egiz/eaaf/core/api/data/EaafConstants.java2
-rw-r--r--eaaf_core_utils/src/main/java/at/gv/egiz/eaaf/core/impl/credential/EaafKeyStoreFactory.java2
-rw-r--r--eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/utils/SL20ResponseUtils.java14
3 files changed, 9 insertions, 9 deletions
diff --git a/eaaf_core_api/src/main/java/at/gv/egiz/eaaf/core/api/data/EaafConstants.java b/eaaf_core_api/src/main/java/at/gv/egiz/eaaf/core/api/data/EaafConstants.java
index 77fdf4fc..cb947219 100644
--- a/eaaf_core_api/src/main/java/at/gv/egiz/eaaf/core/api/data/EaafConstants.java
+++ b/eaaf_core_api/src/main/java/at/gv/egiz/eaaf/core/api/data/EaafConstants.java
@@ -45,7 +45,7 @@ public class EaafConstants {
public static final String URN_PART_CDID = "cdid+";
public static final String URN_PART_ECDID = "ecdid+";
public static final String URN_PART_WBPK = "wbpk+";
- public static final String URN_PART_EWBPK= "ewbpk+";
+ public static final String URN_PART_EWBPK = "ewbpk+";
public static final String URN_PART_EIDAS = "eidasid+";
public static final String URN_PREFIX = "urn:publicid:gv.at";
diff --git a/eaaf_core_utils/src/main/java/at/gv/egiz/eaaf/core/impl/credential/EaafKeyStoreFactory.java b/eaaf_core_utils/src/main/java/at/gv/egiz/eaaf/core/impl/credential/EaafKeyStoreFactory.java
index 63ad3d98..40a74faa 100644
--- a/eaaf_core_utils/src/main/java/at/gv/egiz/eaaf/core/impl/credential/EaafKeyStoreFactory.java
+++ b/eaaf_core_utils/src/main/java/at/gv/egiz/eaaf/core/impl/credential/EaafKeyStoreFactory.java
@@ -189,7 +189,7 @@ public class EaafKeyStoreFactory {
alreadyLoadedProvider.getClass().getMethod(HSM_FACADE_PROVIDER_METHOD_HEALTHCHECK, new Class[]{});
boolean currentHealthStatus = (boolean) healthCheck.invoke(alreadyLoadedProvider);
HsmFacadeStatus status = currentHealthStatus ? HsmFacadeStatus.UP : HsmFacadeStatus.DOWN;
- log.trace("Current HSM-Facade status is: ", status);
+ log.trace("Current HSM-Facade status is: {}", status);
return status;
} catch (final Exception e) {
diff --git a/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/utils/SL20ResponseUtils.java b/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/utils/SL20ResponseUtils.java
index 4bb91634..c3826087 100644
--- a/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/utils/SL20ResponseUtils.java
+++ b/eaaf_modules/eaaf_module_auth_sl20/src/main/java/at/gv/egiz/eaaf/modules/auth/sl20/utils/SL20ResponseUtils.java
@@ -11,17 +11,17 @@ import java.util.UUID;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-import at.gv.egiz.eaaf.core.api.IRequest;
-import at.gv.egiz.eaaf.core.api.data.EaafConstants;
-import at.gv.egiz.eaaf.core.api.idp.IConfiguration;
-import at.gv.egiz.eaaf.modules.auth.sl20.Constants;
-import at.gv.egiz.eaaf.modules.auth.sl20.exceptions.SL20Exception;
-
import org.apache.commons.lang3.StringUtils;
import org.apache.http.client.utils.URIBuilder;
import org.apache.http.entity.ContentType;
import com.fasterxml.jackson.databind.node.ObjectNode;
+
+import at.gv.egiz.eaaf.core.api.IRequest;
+import at.gv.egiz.eaaf.core.api.data.EaafConstants;
+import at.gv.egiz.eaaf.core.api.idp.IConfiguration;
+import at.gv.egiz.eaaf.modules.auth.sl20.Constants;
+import at.gv.egiz.eaaf.modules.auth.sl20.exceptions.SL20Exception;
import lombok.extern.slf4j.Slf4j;
@Slf4j
@@ -134,7 +134,7 @@ public class SL20ResponseUtils {
} else {
log.info("SL2.0 DataURL communication needs http header: '" + SL20Constants.HTTP_HEADER_SL20_CLIENT_TYPE + "'");
- log.debug("Client request containts is no native client ... ");
+ log.debug("Client request is no a native client. SL2.0 anwser will be a http redirect ... ");
final URIBuilder clientRedirectUri = new URIBuilder(fullRedirectUrl);
response.setStatus(Integer.parseInt(authConfig.getBasicConfiguration(Constants.CONFIG_PROP_HTTP_REDIRECT_CODE,
Constants.CONFIG_PROP_HTTP_REDIRECT_CODE_DEFAULT_VALUE)));