From 0199d4dad04d8c0e1e8c531435bbd24956338824 Mon Sep 17 00:00:00 2001 From: Jakob Heher Date: Mon, 8 Aug 2022 11:17:02 +0200 Subject: refactor out the "generic properties map" that is only used by a single property (the signature note) --- .../pdfover/signer/pdfas/PdfAs4SignatureParameter.java | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) (limited to 'pdf-over-signer/src/main/java/at/asit/pdfover/signer/pdfas/PdfAs4SignatureParameter.java') diff --git a/pdf-over-signer/src/main/java/at/asit/pdfover/signer/pdfas/PdfAs4SignatureParameter.java b/pdf-over-signer/src/main/java/at/asit/pdfover/signer/pdfas/PdfAs4SignatureParameter.java index c52625dd..c4999014 100644 --- a/pdf-over-signer/src/main/java/at/asit/pdfover/signer/pdfas/PdfAs4SignatureParameter.java +++ b/pdf-over-signer/src/main/java/at/asit/pdfover/signer/pdfas/PdfAs4SignatureParameter.java @@ -75,18 +75,19 @@ public class PdfAs4SignatureParameter { /** The signature device */ public BKUs signatureDevice; + /** The siganture note, if any */ + public String signatureNote = null; + /** Whether so look for placeholder signatures or not. */ public boolean searchForPlaceholderSignatures = false; - private HashMap genericProperties = new HashMap(); - public Profile signatureProfile = Profile.getDefaultProfile(); public Image getPlaceholder() { String sigProfile = getPdfAsSignatureProfileId(); String sigEmblem = (this.emblem == null ? null : this.emblem.getCachedFileName()); - String sigNote = getProperty("SIG_NOTE"); + String sigNote = this.signatureNote; try { X509Certificate cert = new X509Certificate(PdfAs4SignatureParameter.class.getResourceAsStream("/example.cer")); @@ -133,15 +134,6 @@ public class PdfAs4SignatureParameter { } } - // TODO review this - public void setProperty(String key, String value) { - this.genericProperties.put(key, value); - } - - public String getProperty(String key) { - return this.genericProperties.get(key); - } - /** * Gets the Signature Position String for PDF-AS * @@ -195,7 +187,7 @@ public class PdfAs4SignatureParameter { break; } - if (getProperty("SIG_NOTE") != null) + if (this.signatureNote) profileId += "_NOTE"; if (this.enablePDFACompat) -- cgit v1.2.3