Removed warnings from common package

7 files changed, 27 insertions, 7 deletions

diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PDFIOException.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PDFIOException.java
index 57c1e7ab..5be7b6ec 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PDFIOException.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PDFIOException.java
@@ -9,7 +9,13 @@ package at.gv.egiz.pdfas.common.exceptions;
  */
 public class PDFIOException extends PdfAsException {
 
-    public PDFIOException(String msgId) {
+    /**
+	 * 
+	 */
+	private static final long serialVersionUID = 461085759398146094L;
+
+
+	public PDFIOException(String msgId) {
         super(msgId);
     }
 
diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsException.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsException.java
index e36aa082..21762bb2 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsException.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsException.java
@@ -3,6 +3,11 @@ package at.gv.egiz.pdfas.common.exceptions;
 import at.gv.egiz.pdfas.common.messages.MessageResolver;
 
 public class PdfAsException extends Exception {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = 933244024555676174L;
+
 	public PdfAsException() {
         super();
     }
diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsSettingsException.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsSettingsException.java
index 431ffa5d..ec1d22b0 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsSettingsException.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PdfAsSettingsException.java
@@ -9,7 +9,13 @@ package at.gv.egiz.pdfas.common.exceptions;
  */
 public class PdfAsSettingsException extends PdfAsException {
 
-    public PdfAsSettingsException(String msgId) {
+    /**
+	 * 
+	 */
+	private static final long serialVersionUID = 3277787631624822104L;
+
+
+	public PdfAsSettingsException(String msgId) {
         super(msgId);
     }
 
diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PlaceholderExtractionException.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PlaceholderExtractionException.java
index bef8d245..ff2e48c0 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PlaceholderExtractionException.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/exceptions/PlaceholderExtractionException.java
@@ -1,6 +1,11 @@
 package at.gv.egiz.pdfas.common.exceptions;
 
 public class PlaceholderExtractionException extends PdfAsException {
+	/**
+	 * 
+	 */
+	private static final long serialVersionUID = -6879275004491426233L;
+
 	public PlaceholderExtractionException(String msgId) {
         super(msgId);
     }
diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/messages/MessageResolver.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/messages/MessageResolver.java
index 0bc1bab7..5013d431 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/messages/MessageResolver.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/messages/MessageResolver.java
@@ -18,7 +18,8 @@ public class MessageResolver {
         ResourceBundle bundle = ResourceBundle.getBundle(messageResource);
         if(bundle == null) {
             logger.error("Failed to load resource bundle!!");
-            Runtime.getRuntime().exit(-1);
+            System.err.println("Failed to load resource bundle!!");
+            //Runtime.getRuntime().exit(-1);
         }
     }
 
diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/settings/SignatureProfileSettings.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/settings/SignatureProfileSettings.java
index 4e797ce6..5c443039 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/settings/SignatureProfileSettings.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/settings/SignatureProfileSettings.java
@@ -128,13 +128,11 @@ public class SignatureProfileSettings implements IProfileConstants {
 			String value = entry.getValue();
 
 			if (value == null) {
-				// TODO: try to find default value for key!
 				return getDefaultValue(key);
 			}
 
 			return value;
 		}
-		// TODO: try to find default value for key!
 		return getDefaultValue(key);
 	}
 
diff --git a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/utils/OgnlUtils.java b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/utils/OgnlUtils.java
index 4afb8932..500bd081 100644
--- a/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/utils/OgnlUtils.java
+++ b/pdf-as-common/src/main/java/at/gv/egiz/pdfas/common/utils/OgnlUtils.java
@@ -30,8 +30,7 @@ public class OgnlUtils {
 			}
 			return valueString;
 		} catch (OgnlException e) {
-			// TODO Auto-generated catch block
-			e.printStackTrace();
+			logger.warn("OGNL resolver failed!", e);
 		}
         return expression;
     }