some FIXMEs and TODOs added

git-svn-id: https://joinup.ec.europa.eu/svn/pdf-as/trunk@8 7b5415b0-85f9-ee4d-85bd-d5d0c3b42d1c

2 files changed, 4 insertions, 1 deletions

diff --git a/src/main/java/at/knowcenter/wag/egov/egiz/sig/SignatureObject.java b/src/main/java/at/knowcenter/wag/egov/egiz/sig/SignatureObject.java
index 0d89460..b26abd8 100644
--- a/src/main/java/at/knowcenter/wag/egov/egiz/sig/SignatureObject.java
+++ b/src/main/java/at/knowcenter/wag/egov/egiz/sig/SignatureObject.java
@@ -725,7 +725,7 @@ public class SignatureObject implements Serializable
   public void setSignationIDs(String[] sigIds)

   {

     

-	 // TODO[tknall]: implement workaround resp. failsafe behaviour for ids like "Signature-123456789"

+	 // FIXME[tknall]: implement workaround resp. failsafe behaviour for ids like "Signature-123456789"

 	  

 	  String join = "";

     String base = null;

@@ -1104,6 +1104,8 @@ public class SignatureObject implements Serializable
 		}

    	 

     } else {

+   	 // TODO[tknall]: replace dummy class with real implementing class that uses ldap-mappings from the configuration file

+   	 // TODO[tknall]: don't instantiate class each time; create singleton

    	 logger_.warn("There was no implementation of \"" + LDAPAPI.class.getName() + "\" defined by system property \"" + LDAPAPI.SYS_PROP_IMPLEMENTATION + "\". Using fallback implementation \"" + DummyLDAPAPI.class.getName() + "\".");

        LDAPAPI api = new DummyLDAPAPI(ldap_server_url);

    	 cert = api.loadBase64CertificateFromLDAP(serialNumber, issuer);

diff --git a/src/main/java/at/knowcenter/wag/exactparser/ParseDocument.java b/src/main/java/at/knowcenter/wag/exactparser/ParseDocument.java
index a1ad10d..53da11b 100644
--- a/src/main/java/at/knowcenter/wag/exactparser/ParseDocument.java
+++ b/src/main/java/at/knowcenter/wag/exactparser/ParseDocument.java
@@ -105,6 +105,7 @@ public class ParseDocument
     //HeaderParseResult hpr = PDFUtils.parseHeader(pdf, 0);

     //System.out.println("PDF-version = " + hpr.major + "." + hpr.minor);

     

+	 // FIXME[tknall]: pdf parsing seems to fail if pdf document is really short

     

     List blocks = new ArrayList();