1 files changed, 73 insertions, 18 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/moduls/RequestStorage.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/moduls/RequestStorage.java
index f0b12431a..1b550881e 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/moduls/RequestStorage.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/moduls/RequestStorage.java
@@ -22,39 +22,53 @@
  *******************************************************************************/
 package at.gv.egovernment.moa.id.moduls;
 
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
 import at.gv.egovernment.moa.id.advancedlogging.TransactionIDUtils;
-import at.gv.egovernment.moa.id.auth.exception.MOAIDException;
+import at.gv.egovernment.moa.id.commons.api.IRequest;
+import at.gv.egovernment.moa.id.commons.api.exceptions.MOAIDException;
 import at.gv.egovernment.moa.id.commons.db.ex.MOADatabaseException;
-import at.gv.egovernment.moa.id.storage.AssertionStorage;
+import at.gv.egovernment.moa.id.process.dao.ProcessInstanceStoreDAO;
+import at.gv.egovernment.moa.id.storage.ITransactionStorage;
+import at.gv.egovernment.moa.id.util.Random;
 import at.gv.egovernment.moa.logging.Logger;
 
-public class RequestStorage {
+@Service("RequestStorage")
+public class RequestStorage implements IRequestStorage{
 
-	public static IRequest getPendingRequest(String pendingReqID) {
+	@Autowired ITransactionStorage transactionStorage;
+	@Autowired ProcessInstanceStoreDAO processInstanceStore;
+	
+	@Override
+	public IRequest getPendingRequest(String pendingReqID) {
 		
 		try {
-			AssertionStorage storage = AssertionStorage.getInstance();
-			IRequest pendingRequest = storage.get(pendingReqID, IRequest.class);
-			
+			IRequest pendingRequest = transactionStorage.get(pendingReqID, IRequest.class);
+			if (pendingRequest == null) {
+				Logger.info("No PendingRequst found with pendingRequestID " + pendingReqID);			
+				return null;
+				
+			}
+					
 			//set transactionID and sessionID to Logger
-			TransactionIDUtils.setTransactionId(((IRequest)pendingRequest).getRequestID());
-			TransactionIDUtils.setSessionId(((IRequest)pendingRequest).getSessionIdentifier());
+			TransactionIDUtils.setTransactionId(pendingRequest.getUniqueTransactionIdentifier());
+			TransactionIDUtils.setSessionId(pendingRequest.getUniqueSessionIdentifier());
 			
 			return pendingRequest;
 		
-		} catch (MOADatabaseException e) {
+		} catch (MOADatabaseException | NullPointerException e) {
 			Logger.info("No PendingRequst found with pendingRequestID " + pendingReqID);			
 			return null;
 			
 		}
 	}
 
-	public static void setPendingRequest(Object pendingRequest) throws MOAIDException {
-		try {
-			AssertionStorage storage = AssertionStorage.getInstance();
-			
+	@Override
+	public void storePendingRequest(IRequest pendingRequest) throws MOAIDException {
+		try {			
 			if (pendingRequest instanceof IRequest) {
-				storage.put(((IRequest)pendingRequest).getRequestID(), pendingRequest);
+				transactionStorage.put(((IRequest)pendingRequest).getRequestID(), pendingRequest);
 												
 			} else {
 				throw new MOAIDException("auth.20", null);
@@ -69,12 +83,53 @@ public class RequestStorage {
 		
 	}
 	
-	public static void removePendingRequest(String requestID) {
+	@Override
+	public void removePendingRequest(String requestID) {
 		
 		if (requestID != null) {
-			AssertionStorage storage = AssertionStorage.getInstance();
-			storage.remove(requestID);
 			
+			//remove process-management execution instance
+			try {
+				IRequest pendingReq = getPendingRequest(requestID);
+						
+				if (pendingReq != null && 
+						pendingReq.getProcessInstanceId() != null) {
+					processInstanceStore.remove(pendingReq.getProcessInstanceId());
+					
+				}
+
+			} catch (MOADatabaseException e) {
+				Logger.warn("Removing process associated with pending-request:" + requestID + " FAILED.", e);
+				
+			}
+				
+			transactionStorage.remove(requestID);
+			
+		}
+	}
+
+	/* (non-Javadoc)
+	 * @see at.gv.egovernment.moa.id.storage.IRequestStorage#changePendingRequestID(at.gv.egovernment.moa.id.moduls.IRequest)
+	 */
+	@Override
+	public String changePendingRequestID(IRequest pendingRequest) throws MOAIDException, MOADatabaseException {
+
+		if (pendingRequest instanceof RequestImpl) {
+			String newRequestID = Random.nextRandom();
+			String oldRequestID = pendingRequest.getRequestID();
+			
+			Logger.debug("Change pendingRequestID from " + pendingRequest.getRequestID() 
+				+ " to " + newRequestID);
+			
+			((RequestImpl)pendingRequest).setRequestID(newRequestID);			
+			transactionStorage.changeKey(oldRequestID, newRequestID, pendingRequest);
+			
+			return newRequestID;
+						
+		} else {
+			Logger.error("PendingRequest object is not of type 'RequestImpl.class'");
+			throw new MOAIDException("internal.00", null);
 		}
+		
 	}
 }