refactor magic strings to constants

1 files changed, 9 insertions, 3 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/stork2/AttributeCollector.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/stork2/AttributeCollector.java
index 30f7d3df2..0025307dd 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/stork2/AttributeCollector.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/stork2/AttributeCollector.java
@@ -29,8 +29,15 @@ import eu.stork.peps.auth.commons.PersonalAttribute;
  */
 public class AttributeCollector implements IAction {
 	
+	/** The Constant ARTIFACT_ID. */
+	private static final String ARTIFACT_ID = "artifactId";
+	
 	private ArrayList<AttributeProvider> attributeProviders;
 
+	/** The return url. */
+	// TODO find correct return URL
+	private String returnUrl = "findCorrectReturnURL";
+
 	public AttributeCollector() {
 		// TODO generate from config
 		attributeProviders = new ArrayList<AttributeProvider>();
@@ -101,8 +108,7 @@ public class AttributeCollector implements IAction {
 				AssertionStorage.getInstance().put(newArtifactId, container);
 
 				// add container-key to redirect embedded within the return URL
-				// TODO find correct returnURL
-				e.getAp().performRedirect("returnURL");
+				e.getAp().performRedirect(returnUrl + "?" + ARTIFACT_ID + "=" + newArtifactId);
 			} catch (Exception e1) {
 				// TODO should we return the response as is to the PEPS?
 				Logger.error("Error putting incomplete Stork response into temporary storage", e);
@@ -120,7 +126,7 @@ public class AttributeCollector implements IAction {
      * @see at.gv.egovernment.moa.id.moduls.IAction#needAuthentication(at.gv.egovernment.moa.id.moduls.IRequest, javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)
      */
     public boolean needAuthentication(IRequest req, HttpServletRequest httpReq, HttpServletResponse httpResp) {
-    	// this action does not need any authentication. The authentication is already done by the preceeding AuthenticationRequest-Action.
+    	// this action does not need any authentication. The authentication is already done by the preceding AuthenticationRequest-Action.
         return false;
     }