solve problems with LogOut and Single LogOut

1 files changed, 42 insertions, 21 deletions

diff --git a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/AbstractAuthProtocolModulController.java b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/AbstractAuthProtocolModulController.java
index e6f08abd9..bf00cadaf 100644
--- a/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/AbstractAuthProtocolModulController.java
+++ b/id/server/idserverlib/src/main/java/at/gv/egovernment/moa/id/protocols/AbstractAuthProtocolModulController.java
@@ -34,6 +34,7 @@ import at.gv.egovernment.moa.id.auth.builder.AuthenticationDataBuilder;
 import at.gv.egovernment.moa.id.auth.data.AuthenticationSession;
 import at.gv.egovernment.moa.id.auth.exception.AuthenticationException;
 import at.gv.egovernment.moa.id.auth.servlet.AbstractController;
+import at.gv.egovernment.moa.id.commons.db.ex.MOADatabaseException;
 import at.gv.egovernment.moa.id.config.auth.IOAAuthParameters;
 import at.gv.egovernment.moa.id.data.IAuthData;
 import at.gv.egovernment.moa.id.data.SLOInformationInterface;
@@ -99,9 +100,32 @@ public abstract class AbstractAuthProtocolModulController extends AbstractContro
 		} catch (Exception e) {
 			buildProtocolSpecificErrorResponse(e, req, resp, pendingReq);
 			
+			removeUserSession(pendingReq, req, resp);
+						
 		}		
 	}
 	
+	
+	protected String createNewSSOSessionCookie(HttpServletRequest req, HttpServletResponse resp, 
+			IRequest pendingReq, AuthenticationSession moaSession) {
+		Logger.debug("Add SSO information to MOASession.");
+		
+		//Store SSO information into database
+		String newSSOSessionId = ssomanager.createSSOSessionInformations(moaSession.getSessionID(), 
+				pendingReq.getOAURL());
+
+		//set SSO cookie to response
+		if (MiscUtil.isNotEmpty(newSSOSessionId)) {
+			ssomanager.setSSOSessionID(req, resp, newSSOSessionId);
+	
+		} else {
+			ssomanager.deleteSSOSessionID(req, resp);
+		
+		}
+		
+		return newSSOSessionId;
+	}
+	
 	/**
 	 * Finalize the requested protocol operation
 	 * 
@@ -118,21 +142,7 @@ public abstract class AbstractAuthProtocolModulController extends AbstractContro
 		
 		//if Single Sign-On functionality is enabled for this request
 		if (pendingReq.needSingleSignOnFunctionality()) {
-			
-			Logger.debug("Add SSO information to MOASession.");
-			
-			//Store SSO information into database
-			newSSOSessionId = ssomanager.createSSOSessionInformations(moaSession.getSessionID(), 
-					pendingReq.getOAURL());
-	
-			//set SSO cookie to response
-			if (MiscUtil.isNotEmpty(newSSOSessionId)) {
-				ssomanager.setSSOSessionID(req, resp, newSSOSessionId);
-		
-			} else {
-				ssomanager.deleteSSOSessionID(req, resp);
-			
-			}
+			newSSOSessionId = createNewSSOSessionCookie(req, resp, pendingReq, moaSession);
 			
 		}
 		
@@ -202,6 +212,23 @@ public abstract class AbstractAuthProtocolModulController extends AbstractContro
 		
 	}
 	
+	protected void removeUserSession(IRequest pendingReq, HttpServletRequest req, 
+			HttpServletResponse resp) {		
+		try {
+			AuthenticationSession moaSession = authenticatedSessionStorage.getSession(
+					pendingReq.getMOASessionIdentifier());
+			
+			if (moaSession != null)
+				authmanager.performOnlyIDPLogOut(req, resp, moaSession.getSessionID());
+
+		} catch (MOADatabaseException e) {
+			Logger.error("Remove user-session FAILED." , e);
+			
+		}
+		
+		
+	}
+	
 	protected void buildProtocolSpecificErrorResponse(Throwable throwable, HttpServletRequest req, 
 			HttpServletResponse resp, IRequest protocolRequest) throws IOException {
 		try {
@@ -226,12 +253,6 @@ public abstract class AbstractAuthProtocolModulController extends AbstractContro
 				//log Error Message
 				statisticLogger.logErrorOperation(throwable, protocolRequest);
 				
-				//remove MOASession
-				AuthenticationSession moaSession = authenticatedSessionStorage.getSession(
-						protocolRequest.getMOASessionIdentifier());
-				if (moaSession != null)
-					authmanager.performOnlyIDPLogOut(req, resp, moaSession.getSessionID());
-				
 				return;
 				
 			} else {