From 34dff8116290845953e386c6bfd7d17224a6ad34 Mon Sep 17 00:00:00 2001
From: Thomas <>
Date: Thu, 10 Mar 2022 16:49:48 +0100
Subject: chore(matching): remove some PVP attributes from IDA authentication

---
 .../auth/eidas/v2/idaustriaclient/IdAustriaClientAuthConstants.java   | 4 ----
 .../auth/eidas/v2/tasks/ReceiveMobilePhoneSignatureResponseTask.java  | 2 ++
 .../idaustriaclient/IdAustriaClientAuthMetadataControllerTest.java    | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

(limited to 'modules/authmodule-eIDAS-v2')

diff --git a/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/idaustriaclient/IdAustriaClientAuthConstants.java b/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/idaustriaclient/IdAustriaClientAuthConstants.java
index 46d0e77d..67dfd7d8 100644
--- a/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/idaustriaclient/IdAustriaClientAuthConstants.java
+++ b/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/idaustriaclient/IdAustriaClientAuthConstants.java
@@ -69,10 +69,6 @@ public class IdAustriaClientAuthConstants {
         private static final long serialVersionUID = 1L;
 
         {
-          // add PVP Version attribute
-          add(Triple.newInstance(PvpAttributeDefinitions.PVP_VERSION_NAME,
-              PvpAttributeDefinitions.PVP_VERSION_FRIENDLY_NAME, true));
-
           // entity metadata information
           add(Triple.newInstance(PvpAttributeDefinitions.EID_CITIZEN_EIDAS_QAA_LEVEL_NAME,
               PvpAttributeDefinitions.EID_CITIZEN_EIDAS_QAA_LEVEL_FRIENDLY_NAME, true));
diff --git a/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/ReceiveMobilePhoneSignatureResponseTask.java b/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/ReceiveMobilePhoneSignatureResponseTask.java
index 514e38ba..286b63b1 100644
--- a/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/ReceiveMobilePhoneSignatureResponseTask.java
+++ b/modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/ReceiveMobilePhoneSignatureResponseTask.java
@@ -308,6 +308,7 @@ public class ReceiveMobilePhoneSignatureResponseTask extends AbstractAuthServlet
           IdAustriaClientAuthEventConstants.AUTHPROCESS_ID_AUSTRIA_RESPONSE_RECEIVED,
           response.getID());
       return Pair.newInstance(msg, false);
+      
     } else {
       log.info("Receive StatusCode {} from 'ms-specific eIDAS node'.", response.getStatus().getStatusCode().getValue());
       StatusCode subStatusCode = getSubStatusCode(response);
@@ -315,6 +316,7 @@ public class ReceiveMobilePhoneSignatureResponseTask extends AbstractAuthServlet
           && IdAustriaClientAuthConstants.SAML2_STATUSCODE_USERSTOP.equals(subStatusCode.getValue())) {
         log.info("Find 'User-Stop operation' in SAML2 response. Stopping authentication process ... ");
         return Pair.newInstance(msg, true);
+        
       }
 
       revisionsLogger.logEvent(pendingReq,
diff --git a/modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/idaustriaclient/IdAustriaClientAuthMetadataControllerTest.java b/modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/idaustriaclient/IdAustriaClientAuthMetadataControllerTest.java
index 095a020a..b7f27204 100644
--- a/modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/idaustriaclient/IdAustriaClientAuthMetadataControllerTest.java
+++ b/modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/idaustriaclient/IdAustriaClientAuthMetadataControllerTest.java
@@ -79,7 +79,7 @@ public class IdAustriaClientAuthMetadataControllerTest {
     controller.getSpMetadata(httpReq, httpResp);
 
     //check result
-    validateResponse(7);
+    validateResponse(6);
 
   }
 
-- 
cgit v1.2.3