Remove setting QAA level from CreateIdentityLink

This is already set in ReceiveAuthnResponse

3 files changed, 2 insertions, 25 deletions

diff --git a/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/CreateIdentityLinkTask.java b/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/CreateIdentityLinkTask.java
index d9d45752..c22dc4ba 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/CreateIdentityLinkTask.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/main/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/tasks/CreateIdentityLinkTask.java
@@ -157,7 +157,7 @@ public class CreateIdentityLinkTask extends AbstractAuthServletTask {
           executeIdlMode(eidasAttributes, eidData, personInfo);
         }
       }
-      storeGenericInfoToSession(eidasResponse, eidasAttributes);
+      storeGenericInfoToSession(eidasAttributes);
       requestStoreage.storePendingRequest(pendingReq);
     } catch (final EidasAttributeException e) {
       throw new TaskExecutionException(pendingReq, "Minimum required eIDAS attributeset not found.", e);
@@ -169,14 +169,13 @@ public class CreateIdentityLinkTask extends AbstractAuthServletTask {
     }
   }
 
-  private void storeGenericInfoToSession(ILightResponse eidasResponse, Map<String, Object> eidasAttributes) throws EaafStorageException {
+  private void storeGenericInfoToSession(Map<String, Object> eidasAttributes) throws EaafStorageException {
     AuthProcessDataWrapper authProcessData = getAuthProcessDataWrapper();
     authProcessData.setForeigner(true);
     Triple<String, String, String> eidasPersonalIdentifier = EidasResponseUtils
         .parseEidasPersonalIdentifier((String) eidasAttributes.get(Constants.eIDAS_ATTR_PERSONALIDENTIFIER));
     authProcessData.setGenericDataToSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME,
         Objects.requireNonNull(eidasPersonalIdentifier).getFirst());
-    authProcessData.setQaaLevel(eidasResponse.getLevelOfAssurance());
   }
 
   private void executeIdlMode(Map<String, Object> simpleAttrMap, ErnpEidData eidData, PersonInfoType personInfo) throws EaafException {
diff --git a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskEidNewTest.java b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskEidNewTest.java
index ee7d2ebd..248b71d9 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskEidNewTest.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskEidNewTest.java
@@ -196,10 +196,6 @@ public class CreateIdentityLinkTaskEidNewTest {
     Assert.assertTrue("foreigner process", authProcessData.isForeigner());
     Assert.assertEquals("EID-ISSUING_NATION", "LU",
         authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-    Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-    Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-        authProcessData.getQaaLevel());
-
 
     // check authblock signature
     final AlgorithmConstraints constraints = new AlgorithmConstraints(ConstraintType.PERMIT,
@@ -334,9 +330,6 @@ public class CreateIdentityLinkTaskEidNewTest {
     Assert.assertTrue("foreigner process", authProcessData.isForeigner());
     Assert.assertEquals("EID-ISSUING_NATION", "LU",
         authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-    Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-    Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-        authProcessData.getQaaLevel());
 
     // check vsz request
     ArgumentCaptor<PersonInfoType> argument4 = ArgumentCaptor.forClass(PersonInfoType.class);
diff --git a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskTest.java b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskTest.java
index 4d52566d..556bd2eb 100644
--- a/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskTest.java
+++ b/eidas_modules/authmodule-eIDAS-v2/src/test/java/at/asitplus/eidas/specific/modules/auth/eidas/v2/test/tasks/CreateIdentityLinkTaskTest.java
@@ -165,9 +165,6 @@ public class CreateIdentityLinkTaskTest {
     Assert.assertTrue("foreigner process", authProcessData.isForeigner());
     Assert.assertEquals("EID-ISSUING_NATION", "LU",
         authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-    Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-    Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-        authProcessData.getQaaLevel());
 
     Assert.assertNotNull("IDL", authProcessData.getIdentityLink());
     checkElement("Mustermann", authProcessData.getIdentityLink().getFamilyName());
@@ -217,9 +214,6 @@ public class CreateIdentityLinkTaskTest {
     Assert.assertTrue("foreigner process", authProcessData.isForeigner());
     Assert.assertEquals("EID-ISSUING_NATION", "LU",
         authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-    Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-    Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-        authProcessData.getQaaLevel());
 
     Assert.assertNotNull("no bPK", authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.BPK_NAME));
     Assert.assertEquals("wrong bPK", "FN+123456i:D26vJncPS2W790RH/LP04V+vNOQ=",
@@ -260,9 +254,6 @@ public class CreateIdentityLinkTaskTest {
     Assert.assertTrue("foreigner process", authProcessData.isForeigner());
     Assert.assertEquals("EID-ISSUING_NATION", "LU",
         authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-    Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-    Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-        authProcessData.getQaaLevel());
 
     Assert.assertNotNull("IDL", authProcessData.getIdentityLink());
     checkElement("Musterfrau", authProcessData.getIdentityLink().getFamilyName());
@@ -368,9 +359,6 @@ public class CreateIdentityLinkTaskTest {
       Assert.assertTrue("foreigner process", authProcessData.isForeigner());
       Assert.assertEquals("EID-ISSUING_NATION", "LU",
           authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-      Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-      Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-          authProcessData.getQaaLevel());
 
       Assert.assertNotNull("no bPK", authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.BPK_NAME));
       Assert.assertEquals("wrong bPK", bpk,
@@ -407,9 +395,6 @@ public class CreateIdentityLinkTaskTest {
     Assert.assertTrue("foreigner process", authProcessData.isForeigner());
     Assert.assertEquals("EID-ISSUING_NATION", "LU",
         authProcessData.getGenericDataFromSession(PvpAttributeDefinitions.EID_ISSUING_NATION_NAME, String.class));
-    Assert.assertNotNull("LoA is null", authProcessData.getQaaLevel());
-    Assert.assertEquals("LoA", response.getLevelOfAssurance(),
-        authProcessData.getQaaLevel());
 
     Assert.assertNotNull("IDL", authProcessData.getIdentityLink());