From 95b21a826e5d81fdeabcf4673a9e87047edaec9d Mon Sep 17 00:00:00 2001 From: Thomas Date: Wed, 4 Dec 2019 22:54:51 +0100 Subject: to some more code quality tasks --- .../eaaf/modules/pvp2/idp/api/builder/ISubjectNameIdGenerator.java | 2 +- .../gv/egiz/eaaf/modules/pvp2/idp/impl/AbstractPvp2XProtocol.java | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) (limited to 'eaaf_modules/eaaf_module_pvp2_idp') diff --git a/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/api/builder/ISubjectNameIdGenerator.java b/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/api/builder/ISubjectNameIdGenerator.java index 131be543..e1c21ae7 100644 --- a/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/api/builder/ISubjectNameIdGenerator.java +++ b/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/api/builder/ISubjectNameIdGenerator.java @@ -34,6 +34,6 @@ public interface ISubjectNameIdGenerator { * @return Pair of subjectNameId and NameIdFormat * @throws Pvp2Exception In case of an error */ - public Pair generateSubjectNameId(IAuthData authData, IspConfiguration spConfig) + Pair generateSubjectNameId(IAuthData authData, IspConfiguration spConfig) throws Pvp2Exception; } diff --git a/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/impl/AbstractPvp2XProtocol.java b/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/impl/AbstractPvp2XProtocol.java index 3fac7894..8c74c3fb 100644 --- a/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/impl/AbstractPvp2XProtocol.java +++ b/eaaf_modules/eaaf_module_pvp2_idp/src/main/java/at/gv/egiz/eaaf/modules/pvp2/idp/impl/AbstractPvp2XProtocol.java @@ -409,7 +409,7 @@ public abstract class AbstractPvp2XProtocol extends AbstractController implement if (msg instanceof PvpSProfileRequest && ((PvpSProfileRequest) msg).getSamlRequest() instanceof AuthnRequest) { - preProcessAuthRequest(request, response, pendingReq); + preProcessAuthRequest(request, pendingReq); } else if (childPreProcess(request, response, pendingReq)) { log.debug("Find protocol handler in child implementation"); } else { @@ -430,15 +430,14 @@ public abstract class AbstractPvp2XProtocol extends AbstractController implement * PreProcess Authn request. * * @param request http request - * @param response http response * @param pendingReq current pending request * @throws Throwable in case of an error */ private void preProcessAuthRequest(final HttpServletRequest request, - final HttpServletResponse response, final PvpSProfilePendingRequest pendingReq) + final PvpSProfilePendingRequest pendingReq) throws Throwable { - final PvpSProfileRequest moaRequest = ((PvpSProfileRequest) pendingReq.getRequest()); + final PvpSProfileRequest moaRequest = (PvpSProfileRequest) pendingReq.getRequest(); final SignableXMLObject samlReq = moaRequest.getSamlRequest(); if (!(samlReq instanceof AuthnRequest)) { -- cgit v1.2.3