From fc8aab29eb278a1489a75847efa38ea72b941c79 Mon Sep 17 00:00:00 2001
From: Thomas Lenz <thomas.lenz@egiz.gv.at>
Date: Wed, 5 Feb 2020 11:03:59 +0100
Subject: Extract interface from AbstractCredentialProvider.java Add new
 interface IPvpAddableChainingMetadataProvider.java and implement it in
 AbstractChainingMetadataProvider.java Fix possible nullPointer in
 Saml2Utils.java

---
 .../IPvpAddableChainingMetadataProvider.java       | 22 ++++++++++++++++++++++
 .../metadata/IPvpMetadataConfigurationFactory.java |  4 ++--
 2 files changed, 24 insertions(+), 2 deletions(-)
 create mode 100644 eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpAddableChainingMetadataProvider.java

(limited to 'eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata')

diff --git a/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpAddableChainingMetadataProvider.java b/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpAddableChainingMetadataProvider.java
new file mode 100644
index 00000000..8e5eb715
--- /dev/null
+++ b/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpAddableChainingMetadataProvider.java
@@ -0,0 +1,22 @@
+package at.gv.egiz.eaaf.modules.pvp2.api.metadata;
+
+import javax.annotation.Nonnull;
+
+import at.gv.egiz.eaaf.core.api.IGarbageCollectorProcessing;
+
+import org.opensaml.saml.metadata.resolver.MetadataResolver;
+
+public interface IPvpAddableChainingMetadataProvider {
+
+  /**
+   * Manually add a metadata resolver into a chaining metadata provider.
+   * <br>
+   * <b>If the chaining metadata provider also implements
+   *     {@link IGarbageCollectorProcessing} manually added provider
+   *     can be removed by garbage-collector process. This behavior
+   *     depends on chaining metadata-provider implementation. </b>
+   *
+   * @param resolver Metadata provider that should be added
+   */
+  void addMetadataResolverIntoChain(@Nonnull MetadataResolver resolver);
+}
diff --git a/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpMetadataConfigurationFactory.java b/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpMetadataConfigurationFactory.java
index 0cf7e293..fb1352ce 100644
--- a/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpMetadataConfigurationFactory.java
+++ b/eaaf_modules/eaaf_module_pvp2_core/src/main/java/at/gv/egiz/eaaf/modules/pvp2/api/metadata/IPvpMetadataConfigurationFactory.java
@@ -19,11 +19,11 @@
 
 package at.gv.egiz.eaaf.modules.pvp2.api.metadata;
 
-import at.gv.egiz.eaaf.modules.pvp2.impl.utils.AbstractCredentialProvider;
+import at.gv.egiz.eaaf.modules.pvp2.api.utils.IPvp2CredentialProvider;
 
 public interface IPvpMetadataConfigurationFactory {
 
   IPvpMetadataBuilderConfiguration generateMetadataBuilderConfiguration(String authUrl,
-      AbstractCredentialProvider pvpIdpCredentials);
+      IPvp2CredentialProvider pvpIdpCredentials);
 
 }
-- 
cgit v1.2.3