From 3fada6cef21c9b16467177d866df778203b51b4d Mon Sep 17 00:00:00 2001 From: Thomas Date: Thu, 5 Dec 2019 09:52:48 +0100 Subject: some code code-style modifications active code-quality checks! --- .../impl/idp/module/test/DummyConfiguration.java | 6 ++-- .../idp/module/test/DummyProtocolAuthService.java | 3 -- .../core/impl/idp/module/test/TestRequestImpl.java | 32 ++++++++++++---------- 3 files changed, 21 insertions(+), 20 deletions(-) (limited to 'eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module') diff --git a/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyConfiguration.java b/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyConfiguration.java index 185e1d27..dd3976dd 100644 --- a/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyConfiguration.java +++ b/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyConfiguration.java @@ -3,8 +3,9 @@ package at.gv.egiz.eaaf.core.impl.idp.module.test; import java.net.URI; import java.net.URL; import java.util.Map; + import at.gv.egiz.eaaf.core.api.idp.IConfigurationWithSP; -import at.gv.egiz.eaaf.core.api.idp.IspConfiguration; +import at.gv.egiz.eaaf.core.api.idp.ISpConfiguration; import at.gv.egiz.eaaf.core.exceptions.EaafConfigurationException; import at.gv.egiz.eaaf.core.exceptions.EaafException; import at.gv.egiz.eaaf.core.impl.idp.auth.builder.AbstractAuthenticationDataBuilder; @@ -32,7 +33,7 @@ public class DummyConfiguration implements IConfigurationWithSP { } @Override - public IspConfiguration getServiceProviderConfiguration(final String uniqueID) + public ISpConfiguration getServiceProviderConfiguration(final String uniqueID) throws EaafConfigurationException { // TODO Auto-generated method stub return null; @@ -78,7 +79,6 @@ public class DummyConfiguration implements IConfigurationWithSP { } - return false; } diff --git a/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyProtocolAuthService.java b/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyProtocolAuthService.java index 87f2bcb6..300a390d 100644 --- a/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyProtocolAuthService.java +++ b/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/DummyProtocolAuthService.java @@ -17,7 +17,6 @@ public class DummyProtocolAuthService implements IProtocolAuthenticationService private Throwable exception; private boolean writeToStatisticLog; - @Override public void performAuthentication(final HttpServletRequest req, final HttpServletResponse resp, final IRequest pendingReq) throws IOException, EaafException { @@ -78,6 +77,4 @@ public class DummyProtocolAuthService implements IProtocolAuthenticationService return writeToStatisticLog; } - - } diff --git a/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/TestRequestImpl.java b/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/TestRequestImpl.java index ad80d3ad..8b2dc419 100644 --- a/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/TestRequestImpl.java +++ b/eaaf_core/src/test/java/at/gv/egiz/eaaf/core/impl/idp/module/test/TestRequestImpl.java @@ -23,11 +23,13 @@ import java.io.Serializable; import java.lang.reflect.InvocationTargetException; import java.util.HashMap; import java.util.Map; + +import org.apache.commons.lang3.StringUtils; + import at.gv.egiz.eaaf.core.api.IRequest; -import at.gv.egiz.eaaf.core.api.idp.IspConfiguration; +import at.gv.egiz.eaaf.core.api.idp.ISpConfiguration; import at.gv.egiz.eaaf.core.exceptions.EaafStorageException; import at.gv.egiz.eaaf.core.impl.idp.auth.data.AuthProcessDataWrapper; -import org.apache.commons.lang3.StringUtils; /** * Test pending-request for jUnit tests. @@ -37,8 +39,9 @@ import org.apache.commons.lang3.StringUtils; */ public class TestRequestImpl implements IRequest { + private static final long serialVersionUID = 3000578812622938236L; private String processInstanceID = null; - private IspConfiguration spConfig = null; + private ISpConfiguration spConfig = null; private final Map storage = new HashMap<>(); private String transactionId = null; private String pendingReqId = null; @@ -93,7 +96,8 @@ public class TestRequestImpl implements IRequest { /* * (non-Javadoc) * - * @see at.gv.egovernment.moa.id.moduls.IRequest#getGenericData(java.lang.String) + * @see + * at.gv.egovernment.moa.id.moduls.IRequest#getGenericData(java.lang.String) */ @Override public Object getRawData(final String key) { @@ -103,18 +107,20 @@ public class TestRequestImpl implements IRequest { /* * (non-Javadoc) * - * @see at.gv.egovernment.moa.id.moduls.IRequest#getGenericData(java.lang.String, java.lang.Class) + * @see + * at.gv.egovernment.moa.id.moduls.IRequest#getGenericData(java.lang.String, + * java.lang.Class) */ @Override public T getRawData(final String key, final Class clazz) { return (T) storage.get(key); } - /* * (non-Javadoc) * - * @see at.gv.egovernment.moa.id.moduls.IRequest#getUniqueTransactionIdentifier() + * @see + * at.gv.egovernment.moa.id.moduls.IRequest#getUniqueTransactionIdentifier() */ @Override public String getUniqueTransactionIdentifier() { @@ -192,7 +198,9 @@ public class TestRequestImpl implements IRequest { /* * (non-Javadoc) * - * @see at.gv.egovernment.moa.id.moduls.IRequest#setNeedSingleSignOnFunctionality(boolean) + * @see + * at.gv.egovernment.moa.id.moduls.IRequest#setNeedSingleSignOnFunctionality( + * boolean) */ @Override public void setNeedSingleSignOnFunctionality(final boolean needSso) { @@ -316,7 +324,7 @@ public class TestRequestImpl implements IRequest { } @Override - public IspConfiguration getServiceProviderConfiguration() { + public ISpConfiguration getServiceProviderConfiguration() { return spConfig; } @@ -326,9 +334,7 @@ public class TestRequestImpl implements IRequest { return (T) spConfig; } - - - public void setSpConfig(final IspConfiguration spConfig) { + public void setSpConfig(final ISpConfiguration spConfig) { this.spConfig = spConfig; } @@ -371,6 +377,4 @@ public class TestRequestImpl implements IRequest { this.needAuthentication = needAuthentication; } - - } -- cgit v1.2.3