diff options
| author | Thomas Lenz <thomas.lenz@egiz.gv.at> | 2021-04-19 09:23:41 +0000 | 
|---|---|---|
| committer | Thomas Lenz <thomas.lenz@egiz.gv.at> | 2021-04-19 09:23:41 +0000 | 
| commit | 9e072b7105c4353ea4a193e03efd00f2f63d824c (patch) | |
| tree | 8d0cbfe50fc41ed592ec1b42b83c0c6cae6bbd44 /eaaf_core/src/main/java | |
| parent | 2725ea4a3412a97a8f7ff7031f69970a8382423d (diff) | |
| parent | 3e734a0f1fedba00e594bd69e72bd2f18a0a60bf (diff) | |
| download | EAAF-Components-9e072b7105c4353ea4a193e03efd00f2f63d824c.tar.gz EAAF-Components-9e072b7105c4353ea4a193e03efd00f2f63d824c.tar.bz2 EAAF-Components-9e072b7105c4353ea4a193e03efd00f2f63d824c.zip | |
Merge branch 'feature/VT-21-016' into 'nightlyBuild'
Use custom SSLContext builder to generate BouncyCastle specific TrustManager...
See merge request egiz/eaaf_components!23
Diffstat (limited to 'eaaf_core/src/main/java')
4 files changed, 592 insertions, 205 deletions
| diff --git a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ErrorTicketService.java b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ErrorTicketService.java new file mode 100644 index 00000000..0834aa27 --- /dev/null +++ b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ErrorTicketService.java @@ -0,0 +1,243 @@ +package at.gv.egiz.eaaf.core.impl.idp.auth.services; + +import java.io.InputStream; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; + +import javax.annotation.PostConstruct; +import javax.servlet.http.HttpServletRequest; + +import org.apache.commons.lang3.RandomStringUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.commons.text.StringEscapeUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.core.io.Resource; +import org.springframework.core.io.ResourceLoader; +import org.springframework.stereotype.Service; + +import at.gv.egiz.eaaf.core.api.IStatusMessenger; +import at.gv.egiz.eaaf.core.api.data.EaafConstants; +import at.gv.egiz.eaaf.core.api.idp.IConfiguration; +import at.gv.egiz.eaaf.core.exceptions.EaafException; +import at.gv.egiz.eaaf.core.exceptions.TaskExecutionException; +import at.gv.egiz.eaaf.core.impl.idp.controller.ProtocolFinalizationController; +import at.gv.egiz.eaaf.core.impl.utils.FileUtils; +import at.gv.egiz.eaaf.core.impl.utils.ServletUtils; +import lombok.Getter; + +@Service() +public class ErrorTicketService { +  private static final Logger log = LoggerFactory.getLogger(ErrorTicketService.class); + +  private static final String CONFIG_PROP_ERRORHANDLING_ACTION_PATH = "core.errorhandling.action"; +  private static final String TECH_LOG_MSG = "errorCode={} Message={}"; +  private static final String TICKET_LOG_MSG = "Ticket={} errorCode={} Message={}"; + +  private final HashMap<String, String> propertyMap = new HashMap<String, String>(); + + +  public enum ActionType { +    TICKET_REDIRECT("ticket_redirect"), TICKET_NOREDIRECT("ticket_noredirect"), NOTICKET_REDIRECT( +        "noticket_redirect"), NOTICKET_NOREDIRECT("noticket_noredirect"), NOTICKET_AUTOREDIRECT( +            "noticket_autoredirect"); + +    private final String name; + +    ActionType(final String text) { +      this.name = text; +    } + +    @Override +    public String toString() { +      return name; +    } +  } + +  @Autowired(required = true) +  IConfiguration basicConfig; +  @Autowired(required = true) +  ResourceLoader resourceLoader; + +  @PostConstruct +  private void initialize() throws EaafException { +    log.info("initErrorTicketService"); + +    final String ticketConfPath = basicConfig.getBasicConfiguration(CONFIG_PROP_ERRORHANDLING_ACTION_PATH); +    log.info("ticketConfPath" + ticketConfPath); + + +    if (StringUtils.isEmpty(ticketConfPath)) { +      log.error("Error: Path to errorhandling-action mapping not known"); +      throw new EaafException("internal.configuration.00", +          new Object[]{CONFIG_PROP_ERRORHANDLING_ACTION_PATH}); +    } else { + +      Properties getProperties = new Properties(); +      String fullFilePath = null; +      try { + +        fullFilePath = FileUtils +            .makeAbsoluteUrl(ticketConfPath, basicConfig.getConfigurationRootDirectory()); +        final Resource ressource = resourceLoader.getResource(fullFilePath); +        final InputStream is = ressource.getInputStream(); +        getProperties.load(is); +        is.close(); +        propertyMap.putAll((Map) getProperties); + +        //        log.error(propertyMap.toString()); +        //        log.error("working: " + propertyMap.get("auth.00")); + +      } catch (Exception e) { +        log.error("Error: could not found file.", e); +        throw new EaafException("internal.configuration.01", +            new Object[]{CONFIG_PROP_ERRORHANDLING_ACTION_PATH, "File for errorhandling-action mapping cloud " +                + "not be found."}); +      } +    } +  } + +  /** +   * creates error handling data. +   * @param throwable error +   * @param req http request +   * @return eror handle Data +   * @throws EaafException In case of an internal error +   */ +  public HandleData createHandleData(Throwable throwable, HttpServletRequest req) throws EaafException { +    HandleData data = new HandleData(throwable, req); +    extractErrorCode(data); +    setUpErrorData(data); + +    return data; +  } + +  private void extractErrorCode(HandleData data) { +    Throwable originalException; +    if (data.throwable instanceof TaskExecutionException +        && ((TaskExecutionException) data.throwable).getOriginalException() != null) { +      originalException = ((TaskExecutionException) data.throwable).getOriginalException(); + +    } else { +      originalException = data.throwable; + +    } + +    if (!(originalException instanceof EaafException)) { +      data.errorCode = IStatusMessenger.CODES_INTERNAL_ERROR_GENERIC; + +    } else { +      data.errorCode = ((EaafException) originalException).getErrorId(); + +    } +  } + +  private void setUpErrorData(HandleData data) throws EaafException { + +    if (propertyMap.containsKey(data.errorCode)) { +      String action = propertyMap.get(data.errorCode); + +      if (action.equals(ActionType.TICKET_REDIRECT.toString())) { +        data.actionType = ActionType.TICKET_REDIRECT; +        data.generateSupportTicket(); +        data.generateRedirect(); + +      } else if (action.equals(ActionType.TICKET_NOREDIRECT.toString())) { +        data.actionType = ActionType.TICKET_NOREDIRECT; +        data.generateSupportTicket(); + +      } else if (action.equals(ActionType.NOTICKET_REDIRECT.toString())) { +        data.actionType = ActionType.NOTICKET_REDIRECT; +        data.generateRedirect(); + +      } else if (action.equals(ActionType.NOTICKET_AUTOREDIRECT.toString())) { +        data.actionType = ActionType.NOTICKET_AUTOREDIRECT; + +      } else { // ActionType.NOTICKET_NOREDIRECT -> nothing to be done +        data.actionType = ActionType.NOTICKET_NOREDIRECT; + +      } + +    } else { +      data.generateSupportTicket(); +      throw new EaafException("internal.configuration.00", +          new Object[]{data.errorCode + " in on_error_action" + ".properties"}); +    } +  } + +  static class HandleData { +    private final HttpServletRequest req; +    @Getter +    private String supportTicket; +    @Getter +    private String redirectUrl; +    @Getter +    private final Throwable throwable; +    @Getter +    private String errorCode; +    @Getter +    private ActionType actionType; + + +    private HandleData(Throwable throwable, HttpServletRequest req) { +      this.throwable = throwable; +      this.req = req; +    } + +    private void generateRedirect() { +      redirectUrl = ServletUtils.getBaseUrl(req); +      redirectUrl += +          ProtocolFinalizationController.ENDPOINT_ERROR_REDIRECT + "?" + EaafConstants.PARAM_HTTP_ERROR_CODE + "=" +              + StringEscapeUtils.escapeHtml4(req.getParameter(EaafConstants.PARAM_HTTP_ERROR_CODE)); + +    } + +    private void generateSupportTicket() { + +      String randomCode = +          RandomStringUtils.randomAlphanumeric(4).toUpperCase() + '-' + RandomStringUtils.randomAlphanumeric(4) +              .toUpperCase() + '-' + RandomStringUtils.randomAlphanumeric(4).toUpperCase(); +      supportTicket = randomCode; +    } + +    /** +     *  Logs error to technical log. +     */ +    public void log_error() { + +      if (supportTicket != null) { +        log.error(TICKET_LOG_MSG, supportTicket, errorCode, throwable.getMessage(), throwable); +      } else { +        log.error(TECH_LOG_MSG, errorCode, throwable.getMessage(), throwable); +      } +    } + +    /** +     * Logs info to technical log. +     */ +    public void log_info() { + +      if (supportTicket != null) { +        log.info(TICKET_LOG_MSG, supportTicket, errorCode, throwable.getMessage(), throwable); + +      } else { +        log.info(TECH_LOG_MSG, errorCode, throwable.getMessage(), throwable); +      } +    } + +    /** +     * Logs warn to technical log. +     */ +    public void log_warn() { + +      if (supportTicket != null) { +        log.warn(TICKET_LOG_MSG, supportTicket, errorCode, throwable.getMessage(), throwable); + +      } else { +        log.warn(TECH_LOG_MSG, errorCode, throwable.getMessage(), throwable); +      } +    } +  } +} diff --git a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/IErrorService.java b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/IErrorService.java new file mode 100644 index 00000000..812a5171 --- /dev/null +++ b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/IErrorService.java @@ -0,0 +1,92 @@ +package at.gv.egiz.eaaf.core.impl.idp.auth.services; + +import at.gv.egiz.eaaf.core.api.gui.ModifyableGuiBuilderConfiguration; +import at.gv.egiz.eaaf.core.exceptions.EaafException; + +import javax.servlet.http.HttpServletRequest; +import java.util.HashSet; + +public interface IErrorService { +  /** +   * Describes the kind of action that should be taken. +   */ +  enum ActionType { +    TICKET_REDIRECT("ticket_redirect"), TICKET_NOREDIRECT("ticket_noredirect"), NOTICKET_REDIRECT( +        "noticket_redirect"), NOTICKET_NOREDIRECT("noticket_noredirect"), NOTICKET_AUTOREDIRECT( +        "noticket_autoredirect"); + +    private final String name; + +    ActionType(final String text) { +      this.name = text; +    } + +    @Override +    public String toString() { +      return name; +    } +  } + +  String PARAM_GUI_TICKET = "supportTicket"; +  String PARAM_GUI_REDIRECT = "redirectLink"; + +  /** +   * Maps internal error codes to external ones. +   * @param internalCode internal error code +   * @return external error code +   */ +  String getExternalCodeFromInternal(String internalCode); + +  /** +   * creates error handling data. +   * +   * @param throwable error +   * @param req       http request +   * @return eror handle Data +   * @throws EaafException In case of an internal error +   */ +  IHandleData createHandleData(Throwable throwable, HttpServletRequest req) throws EaafException; + +  /** +   * Displays the error using suitable errordata. +   * +   * @param c         guibuilder +   * @param errorData Data to handle +   * @throws EaafException In case of an internal error +   */ +  void displayErrorData(ModifyableGuiBuilderConfiguration c, IErrorService.IHandleData errorData) +      throws EaafException; + +  /** +   * Contains all the Model data for Error Handling. +   */ +  interface IHandleData { +    /** +     * Describes the kind of action that should be taken. +     * +     * @return The appropriate action +     */ +    ActionType getActionType(); + +    /** +     * Get internal errorCode describing the problem. +     * +     * @return internal error Code. +     */ +    String getInternalErrorCode(); + +    /** +     * Get the original throwable of the error. +     * +     * @return causing throwable +     */ +    Throwable getThrowable(); + +    /** +     * Write a Exception to the MOA-ID-Auth internal technical log. +     * +     * @param logOnInfoLevel set of what to log on info logging lvl +     */ +    void logExceptionToTechnicalLog(HashSet<String> logOnInfoLevel); +  } +} diff --git a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java index abb3d685..a64ad45e 100644 --- a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java +++ b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java @@ -15,7 +15,7 @@   * This product combines work with different licenses. See the "NOTICE" text file for details on the   * various modules and licenses. The "NOTICE" text file is part of the distribution. Any derivative   * works that you distribute must include a readable copy of the "NOTICE" text file. -*/ + */  package at.gv.egiz.eaaf.core.impl.idp.auth.services; @@ -38,12 +38,14 @@ import org.springframework.context.ApplicationContext;  import org.springframework.lang.NonNull;  import org.springframework.lang.Nullable;  import org.springframework.stereotype.Service; +import org.springframework.util.SerializationUtils;  import at.gv.egiz.components.eventlog.api.EventConstants;  import at.gv.egiz.eaaf.core.api.IRequest;  import at.gv.egiz.eaaf.core.api.IRequestStorage;  import at.gv.egiz.eaaf.core.api.IStatusMessenger;  import at.gv.egiz.eaaf.core.api.data.EaafConstants; +import at.gv.egiz.eaaf.core.api.data.ExceptionContainer;  import at.gv.egiz.eaaf.core.api.gui.IGuiBuilderConfiguration;  import at.gv.egiz.eaaf.core.api.gui.IGuiBuilderConfigurationFactory;  import at.gv.egiz.eaaf.core.api.gui.IGuiFormBuilder; @@ -60,6 +62,7 @@ import at.gv.egiz.eaaf.core.api.idp.auth.services.IProtocolAuthenticationService  import at.gv.egiz.eaaf.core.api.idp.slo.SloInformationInterface;  import at.gv.egiz.eaaf.core.api.logging.IRevisionLogger;  import at.gv.egiz.eaaf.core.api.logging.IStatisticLogger; +import at.gv.egiz.eaaf.core.api.storage.ITransactionStorage;  import at.gv.egiz.eaaf.core.api.utils.IPendingRequestIdGenerationStrategy;  import at.gv.egiz.eaaf.core.exceptions.AuthnRequestValidatorException;  import at.gv.egiz.eaaf.core.exceptions.EaafAuthenticationException; @@ -69,7 +72,6 @@ import at.gv.egiz.eaaf.core.exceptions.GuiBuildException;  import at.gv.egiz.eaaf.core.exceptions.InvalidProtocolRequestException;  import at.gv.egiz.eaaf.core.exceptions.ProcessExecutionException;  import at.gv.egiz.eaaf.core.exceptions.ProtocolNotActiveException; -import at.gv.egiz.eaaf.core.exceptions.TaskExecutionException;  import at.gv.egiz.eaaf.core.impl.data.Pair;  import at.gv.egiz.eaaf.core.impl.gui.AbstractGuiFormBuilderConfiguration;  import at.gv.egiz.eaaf.core.impl.http.HttpUtils; @@ -78,13 +80,14 @@ import at.gv.egiz.eaaf.core.impl.idp.controller.protocols.RequestImpl;  import at.gv.egiz.eaaf.core.impl.utils.KeyValueUtils;  import at.gv.egiz.eaaf.core.impl.utils.ServletUtils; + + +  @Service  public class ProtocolAuthenticationService implements IProtocolAuthenticationService {    private static final Logger log = LoggerFactory.getLogger(ProtocolAuthenticationService.class); -  private static final String CONFIG_PROP_LOGGER_ON_INFO_LEVEL = -      "core.logging.level.info.errorcodes"; -  private static final String TECH_LOG_MSG = "errorCode={} Message={}"; +  private static final String CONFIG_PROP_LOGGER_ON_INFO_LEVEL = "core.logging.level.info.errorcodes";    @Autowired(required = true)    private ApplicationContext applicationContext; @@ -100,15 +103,28 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer    private IRequestStorage requestStorage;    @Autowired(required = true)    IPendingRequestIdGenerationStrategy pendingReqIdGenerationStrategy; -  @Autowired private IConfiguration basicConfig; +  @Autowired +  private IConfiguration basicConfig; + +  @Autowired(required = true) +  private IErrorService errorTicketService;    @Autowired(required = false)    private ISsoManager ssoManager; +    @Autowired    private IStatisticLogger statisticLogger; +      @Autowired    private IRevisionLogger revisionsLogger; +  @Autowired(required = true) +  protected ITransactionStorage transactionStorage; + +  @Autowired +  IPendingRequestIdGenerationStrategy requestIdValidationStragegy; + +    private IGuiFormBuilder guiBuilder;    private final HashSet<String> logOnInfoLevel = new HashSet<>(); @@ -136,9 +152,8 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer          final ISpConfiguration oaParam = pendingReq.getServiceProviderConfiguration();          if (oaParam == null) { -          throw new EaafAuthenticationException( -              IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_NOSPCONFIG, -              new Object[] { pendingReq.getSpEntityId() }); +          throw new EaafAuthenticationException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_NOSPCONFIG, +              new Object[]{pendingReq.getSpEntityId()});          }          if (authmanager.doAuthentication(req, resp, pendingReq)) { @@ -148,8 +163,7 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer            finalizeAuthentication(req, resp, pendingReq);            // transaction is finished, log transaction finished event -          revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, -              pendingReq.getUniqueTransactionIdentifier()); +          revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, pendingReq.getUniqueTransactionIdentifier());          } @@ -183,9 +197,8 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer        if (pendingReq.isAbortedByUser()) {          // send authentication aborted error to Service Provider          buildProtocolSpecificErrorResponse( -            new EaafAuthenticationException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_USERSTOP, -                new Object[] {}), -            req, resp, pendingReq); +            new EaafAuthenticationException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_USERSTOP, new Object[]{}), req, +            resp, pendingReq);          // check if pending-request are authenticated        } else if (pendingReq.isAuthenticated() && !pendingReq.isNeedUserConsent()) { @@ -193,11 +206,10 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer        } else {          // suspect state: pending-request is not aborted but also are not authenticated -        log.warn("PendingRequest flag for 'authenticated':{} and 'needConsent':{}", -            pendingReq.isAuthenticated(), pendingReq.isNeedUserConsent()); +        log.warn("PendingRequest flag for 'authenticated':{} and 'needConsent':{}", pendingReq.isAuthenticated(), +            pendingReq.isNeedUserConsent());          if (pendingReq.isNeedUserConsent()) { -          log.error( -              "PendingRequest NEEDS user-consent. " +          log.error("PendingRequest NEEDS user-consent. "                + "Can NOT fininalize authentication --> Abort authentication process!");          } else { @@ -216,58 +228,97 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer      } finally {        // remove pending-request        requestStorage.removePendingRequest(pendingReq.getPendingRequestId()); -      revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, -          pendingReq.getUniqueTransactionIdentifier()); +      revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, pendingReq.getUniqueTransactionIdentifier());      }    } +    @Override -  public void buildProtocolSpecificErrorResponse(final Throwable throwable, -      final HttpServletRequest req, final HttpServletResponse resp, final IRequest protocolRequest) -      throws EaafException, IOException { +  public void buildProtocolSpecificErrorResponse(final Throwable throwable, final HttpServletRequest req, +      final HttpServletResponse resp, final IRequest protocolRequest) throws EaafException, IOException {      try { +      IErrorService.IHandleData errorData = errorTicketService.createHandleData(throwable, req); +       +      if (errorData.getActionType().equals(IErrorService.ActionType.TICKET_REDIRECT) || errorData.getActionType() +          .equals(IErrorService.ActionType.NOTICKET_REDIRECT)) { -      final Class<?> clazz = Class.forName(protocolRequest.requestedModule()); +        // Put pending request +        ExceptionContainer exceptionContainer = new ExceptionContainer(protocolRequest, throwable); +        byte[] serialized = SerializationUtils.serialize(exceptionContainer); +        //        transactionStorage.put(req.getParameter(EaafConstants.PARAM_HTTP_ERROR_CODE), serialized, -1); +        String errorId = requestIdValidationStragegy +            .validateAndGetPendingRequestId(req.getParameter(EaafConstants.PARAM_HTTP_ERROR_CODE)); +        transactionStorage.put(errorId, serialized, -1); -      if (clazz == null || !IModulInfo.class.isAssignableFrom(clazz)) { -        log.error( -            "Requested protocol module Class is NULL or does not implement the IModulInfo interface."); -        throw new ClassCastException( -            "Requested protocol module Class is NULL or does not implement the IModulInfo interface."); +        // log Error to technical log +        errorData.logExceptionToTechnicalLog(logOnInfoLevel); -      } +        // log Error Message +        statisticLogger.logErrorOperation(throwable, protocolRequest); -      final IModulInfo handlingModule = (IModulInfo) applicationContext.getBean(clazz); +        displayException(req, resp, errorData); -      if (handlingModule.generateErrorMessage(throwable, req, resp, protocolRequest)) { +      } else if (errorData.getActionType().equals(IErrorService.ActionType.NOTICKET_AUTOREDIRECT)) { +        IModulInfo handlingModule = extractShibbolethHandling(protocolRequest, applicationContext); -        // log Error to technical log -        logExceptionToTechnicalLog(throwable); +        if (handlingModule.generateErrorMessage(throwable, req, resp, protocolRequest)) { -        // log Error Message -        statisticLogger.logErrorOperation(throwable, protocolRequest); +          // log Error to technical log +          errorData.logExceptionToTechnicalLog(logOnInfoLevel); + +          // log Error Message +          statisticLogger.logErrorOperation(throwable, protocolRequest); + +          // write revision log entries +          revisionsLogger.logEvent(protocolRequest, EventConstants.TRANSACTION_ERROR, +              protocolRequest.getUniqueTransactionIdentifier()); -        // write revision log entries -        revisionsLogger.logEvent(protocolRequest, EventConstants.TRANSACTION_ERROR, -            protocolRequest.getUniqueTransactionIdentifier()); +        } else { +          throw throwable; //through it on to handleErrorNoRedirect + +        }        } else { -        handleErrorNoRedirect(throwable, req, resp, true); +        throw throwable; //through it on to handleErrorNoRedirect        }      } catch (final Throwable e) { -      handleErrorNoRedirect(throwable, req, resp, true); - +      // if building error response results in error, we try with with handleErrorNoRedirect +      handleErrorNoRedirect(e, req, resp, true);      } +  } +  /** +   * Retrieves shibboleth module info. +   * +   * @param protocolRequest    current request +   * @param applicationContext spring context +   * @return IModulInfo +   * @throws ClassNotFoundException If no shibboleth handling implementation found +   */ +  public static IModulInfo extractShibbolethHandling(IRequest protocolRequest, ApplicationContext applicationContext) +      throws ClassNotFoundException { +    final Class<?> clazz = Class.forName(protocolRequest.requestedModule()); + +    if (clazz == null || !IModulInfo.class.isAssignableFrom(clazz)) { +      log.error("Requested protocol module Class is NULL or does not implement the IModulInfo interface."); +      throw new ClassCastException( +          "Requested protocol module Class is NULL or does not implement the IModulInfo interface."); + +    } +     +    return (IModulInfo) applicationContext.getBean(clazz);    } +    @Override    public void handleErrorNoRedirect(final Throwable throwable, final HttpServletRequest req, -      final HttpServletResponse resp, final boolean writeExceptionToStatisticLog) -      throws IOException, EaafException { +      final HttpServletResponse resp, final boolean writeExceptionToStatisticLog) throws EaafException, IOException { + +    IErrorService.IHandleData errorData = null; +    errorData = errorTicketService.createHandleData(throwable, req);      // log Exception into statistic database      if (writeExceptionToStatisticLog) { @@ -275,30 +326,25 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer      }      // write errror to console -    logExceptionToTechnicalLog(throwable); - -    // return error to Web browser -    if (throwable instanceof EaafException || throwable instanceof ProcessExecutionException) { -      internalMoaidExceptionHandler(req, resp, (Exception) throwable, false); +    errorData.logExceptionToTechnicalLog(logOnInfoLevel); +    if (errorData.getActionType().equals(IErrorService.ActionType.NOTICKET_NOREDIRECT) || errorData +        .getActionType().equals(IErrorService.ActionType.TICKET_NOREDIRECT)) { +      // return error to Web browser +      displayException(req, resp, errorData);      } else { -      // write generic message for general exceptions -      final String msg = -          statusMessager.getMessage(IStatusMessenger.CODES_INTERNAL_ERROR_GENERIC, null); -      final String internalErrorCode = statusMessager.getResponseErrorCode(throwable); -       -      writeHtmlErrorResponse(req, resp, msg, internalErrorCode, null, -          statusMessager.mapInternalErrorToExternalError(internalErrorCode)); - +      // TODO introduce separate error type? +      throw new EaafException("internal.configuration.01", new Object[]{ +          errorData.getInternalErrorCode() + " in on_error_action" + ".properties", "Erroraction mapping mismatch"});      } -    } +    @Override    public void forwardToErrorHandler(Pair<IRequest, Throwable> errorToHandle, String errorKey,        final HttpServletRequest req, final HttpServletResponse resp) throws GuiBuildException { -    final IGuiBuilderConfiguration parentHopGuiConfig = -        evaluateRequiredErrorHandlingMethod(errorToHandle.getFirst(), errorKey); +    final IGuiBuilderConfiguration parentHopGuiConfig = evaluateRequiredErrorHandlingMethod(errorToHandle.getFirst(), +        errorKey);      if (parentHopGuiConfig != null) {        log.trace("iFrame to parent hop requested. Building GUI step for error handling ... ");        guiBuilder.build(req, resp, parentHopGuiConfig, "iFrame-to-parent"); @@ -321,15 +367,13 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer    /**     * Finalize the requested protocol operation.     * -   * @param httpReq         HttpServletRequest -   * @param httpResp        HttpServletResponse -   * @param protocolRequest Authentication request which is actually in process -   * @param moaSession      MOASession object, which is used to generate the -   *                        protocol specific authentication information +   * @param req        HttpServletRequest +   * @param resp       HttpServletResponse +   * @param pendingReq Authentication request which is actually in process     * @throws Exception In case of an error     */ -  protected void internalFinalizeAuthenticationProcess(final HttpServletRequest req, -      final HttpServletResponse resp, final IRequest pendingReq) throws Exception { +  protected void internalFinalizeAuthenticationProcess(final HttpServletRequest req, final HttpServletResponse resp, +      final IRequest pendingReq) throws Exception {      String newSsoSessionId = null; @@ -351,8 +395,7 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer      final IAuthData authData = authDataBuilder.buildAuthenticationData(pendingReq);      // execute the protocol-specific action -    final SloInformationInterface sloInformation = -        executeProtocolSpecificAction(req, resp, pendingReq, authData); +    final SloInformationInterface sloInformation = executeProtocolSpecificAction(req, resp, pendingReq, authData);      // Store OA specific SSO session information if an SSO cookie is set      if (StringUtils.isNotEmpty(newSsoSessionId)) { @@ -372,52 +415,15 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer      }      // Advanced statistic logging -    statisticLogger.logSuccessOperation(pendingReq, authData, -        StringUtils.isNotEmpty(newSsoSessionId)); +    statisticLogger.logSuccessOperation(pendingReq, authData, StringUtils.isNotEmpty(newSsoSessionId));    } -  /** -   * Write a Exception to the MOA-ID-Auth internal technical log. -   * -   * @param loggedException Exception to log -   */ -  protected void logExceptionToTechnicalLog(final Throwable loggedException) {     -    // In case of a TaskExecutionException, which is only a container for process-errors,  -    // extract internal exception  -    Throwable toLog; -    if (loggedException instanceof TaskExecutionException  -        && ((TaskExecutionException)loggedException).getOriginalException() != null) { -      toLog = ((TaskExecutionException)loggedException).getOriginalException(); -       -    } else { -      toLog = loggedException; -       -    } - -    // Log exception -    if (!(toLog instanceof EaafException)) { -      log.error(TECH_LOG_MSG, IStatusMessenger.CODES_INTERNAL_ERROR_GENERIC, -          toLog.getMessage(), toLog); - -    } else {             -      if (logOnInfoLevel.contains(((EaafException) toLog).getErrorId())) { -        log.info(TECH_LOG_MSG, ((EaafException) toLog).getErrorId(), -            toLog.getMessage(), toLog); - -      } else { -        log.warn(TECH_LOG_MSG, ((EaafException) toLog).getErrorId(), -            toLog.getMessage(), toLog); - -      } -    } -  } -    @PostConstruct    private void initializer() {      log.trace("Initializing {} ...", ProtocolAuthenticationService.class.getName()); -    logOnInfoLevel.addAll(KeyValueUtils.getListOfCsvValues( -        basicConfig.getBasicConfiguration(CONFIG_PROP_LOGGER_ON_INFO_LEVEL))); +    logOnInfoLevel +        .addAll(KeyValueUtils.getListOfCsvValues(basicConfig.getBasicConfiguration(CONFIG_PROP_LOGGER_ON_INFO_LEVEL)));      log.info("Set errorCodes={} to LogLevel:INFO", String.join(",", logOnInfoLevel));    } @@ -425,24 +431,20 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer    /**     * Executes the requested protocol action.     * -   * @param httpReq         HttpServletRequest -   * @param httpResp        HttpServletResponse -   * @param protocolRequest Authentication request which is actually in process -   * @param authData        Service-provider specific authentication data -   * +   * @param httpReq    HttpServletRequest +   * @param httpResp   HttpServletResponse +   * @param pendingReq Authentication request which is actually in process +   * @param authData   Service-provider specific authentication data     * @return Return Single LogOut information or null if protocol supports no SSO -   *     * @throws Exception in case of an error     */    private SloInformationInterface executeProtocolSpecificAction(final HttpServletRequest httpReq, -      final HttpServletResponse httpResp, final IRequest pendingReq, final IAuthData authData) -      throws Exception { +      final HttpServletResponse httpResp, final IRequest pendingReq, final IAuthData authData) throws Exception {      try {        // request needs no authentication --> start request processing        final Class<?> clazz = Class.forName(pendingReq.requestedAction());        if (clazz == null || !IAction.class.isAssignableFrom(clazz)) { -        log.error( -            "Requested protocol-action processing Class is NULL or does not implement the IAction interface."); +        log.error("Requested protocol-action processing Class is NULL or does not implement the IAction interface.");          throw new ClassCastException(              "Requested protocol-action processing Class is NULL or does not implement the IAction interface."); @@ -452,25 +454,33 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer        return protocolAction.processRequest(pendingReq, httpReq, httpResp, authData);      } catch (final ClassNotFoundException e) { -      log.error( -          "Requested Auth. protocol processing Class is NULL or does not implement the IAction interface."); +      log.error("Requested Auth. protocol processing Class is NULL or does not implement the IAction interface.");        throw new ClassNotFoundException(            "Requested Auth. protocol processing Class is NULL or does not implement the IAction interface.", e);      }    } + +  //  private void writeHtmlErrorResponse(@NonNull final HttpServletRequest httpReq, +  //      @NonNull final HttpServletResponse httpResp, @NonNull final String msg, @NonNull final String errorCode, +  //      @Nullable final Object[] params, String externalErrorCode) throws EaafException { +  //    this.writeHtmlErrorResponse(httpReq, httpResp, msg, errorCode, params, externalErrorCode, null, null); +  //  } + +    private void writeHtmlErrorResponse(@NonNull final HttpServletRequest httpReq, -      @NonNull final HttpServletResponse httpResp, @NonNull final String msg, -      @NonNull final String errorCode, @Nullable final Object[] params, String externalErrorCode) throws EaafException { +      @NonNull final HttpServletResponse httpResp, @NonNull final String msg, @NonNull final String errorCode, +      @Nullable final Object[] params, String externalErrorCode, IErrorService.IHandleData errorData) +      throws EaafException {      try { -      final IGuiBuilderConfiguration config = -          guiConfigFactory.getDefaultErrorGui(HttpUtils.extractAuthUrlFromRequest(httpReq)); +      final IGuiBuilderConfiguration config = guiConfigFactory +          .getDefaultErrorGui(HttpUtils.extractAuthUrlFromRequest(httpReq));        String[] errorCodeParams = null;        if (params == null) { -        errorCodeParams = new String[] {}; +        errorCodeParams = new String[]{};        } else {          errorCodeParams = new String[params.length];          for (int i = 0; i < params.length; i++) { @@ -485,20 +495,19 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer        // add errorcode and errormessage        if (config instanceof ModifyableGuiBuilderConfiguration) { -        ((ModifyableGuiBuilderConfiguration) config).putCustomParameter( -            AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_ERROMSG, msg); -        ((ModifyableGuiBuilderConfiguration) config).putCustomParameter( -            AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_ERRORCODE, errorCode); -        ((ModifyableGuiBuilderConfiguration) config).putCustomParameter( -            AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_EXTERNAL_ERRORCODE,  -            externalErrorCode);                         -        ((ModifyableGuiBuilderConfiguration) config).putCustomParameterWithOutEscaption( -            AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_ERRORCODEPARAMS, -            ArrayUtils.toString(errorCodeParams)); +        ModifyableGuiBuilderConfiguration c = (ModifyableGuiBuilderConfiguration) config; +        c.putCustomParameter(AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_ERROMSG, msg); +        c.putCustomParameter(AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_ERRORCODE, errorCode); +        // TODO: should we keep the internal errorcode secret? +        c.putCustomParameter(AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, PARAM_GUI_EXTERNAL_ERRORCODE, +            externalErrorCode); +        c.putCustomParameterWithOutEscaption(AbstractGuiFormBuilderConfiguration.PARAM_GROUP_MSG, +            PARAM_GUI_ERRORCODEPARAMS, ArrayUtils.toString(errorCodeParams)); +        errorTicketService.displayErrorData(c, errorData); +        } else { -        log.info( -            "Can not ADD error message, because 'GUIBuilderConfiguration' is not modifieable "); +        log.info("Can not ADD error message, because 'GUIBuilderConfiguration' is not modifieable ");        }        guiBuilder.build(httpReq, httpResp, config, "Error-Message"); @@ -511,60 +520,44 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer    } -  private void internalMoaidExceptionHandler(final HttpServletRequest req, -      final HttpServletResponse resp, final Exception e, final boolean writeExceptionToStatisicLog) -      throws IOException, EaafException {     -    final String internalErrorCode = statusMessager.getResponseErrorCode(e); -     +  private void displayException(final HttpServletRequest req, final HttpServletResponse resp, +      final IErrorService.IHandleData errorData) throws IOException, EaafException { +    final Throwable e = errorData.getThrowable(); +    final String internalErrorCode = errorData.getInternalErrorCode(); + +    // send error response      if (e instanceof ProtocolNotActiveException) {        resp.getWriter().write(Encode.forHtml(e.getMessage()));        resp.setContentType(EaafConstants.CONTENTTYPE_HTML_UTF8);        resp.sendError(HttpServletResponse.SC_FORBIDDEN,            StringEscapeUtils.escapeHtml4(StringEscapeUtils.escapeEcmaScript(e.getMessage()))); -    } else if (e instanceof AuthnRequestValidatorException) { -      final AuthnRequestValidatorException ex = (AuthnRequestValidatorException) e; -      // log Error Message -      if (writeExceptionToStatisicLog) { -        statisticLogger.logErrorOperation(ex, ex.getErrorRequest()); -      } -             +    } else if (e instanceof AuthnRequestValidatorException || e instanceof InvalidProtocolRequestException +        || e instanceof ProcessExecutionException || e instanceof ConfigurationException) {        // write error message        writeHtmlErrorResponse(req, resp, e.getMessage(), internalErrorCode, null, -          statusMessager.mapInternalErrorToExternalError(internalErrorCode)); - -    } else if (e instanceof InvalidProtocolRequestException) { -      // send error response -      writeHtmlErrorResponse(req, resp, e.getMessage(), internalErrorCode, null, -          statusMessager.mapInternalErrorToExternalError(internalErrorCode)); - -    } else if (e instanceof ConfigurationException) { -      // send HTML formated error message -      writeHtmlErrorResponse(req, resp, e.getMessage(), internalErrorCode, null, -          statusMessager.mapInternalErrorToExternalError(internalErrorCode)); +          statusMessager.mapInternalErrorToExternalError(internalErrorCode), errorData);      } else if (e instanceof EaafException) {        // send HTML formated error message -      writeHtmlErrorResponse(req, resp, e.getMessage(), internalErrorCode, -          ((EaafException) e).getParams(), statusMessager.mapInternalErrorToExternalError(internalErrorCode)); +      writeHtmlErrorResponse(req, resp, e.getMessage(), internalErrorCode, ((EaafException) e).getParams(), +          statusMessager.mapInternalErrorToExternalError(internalErrorCode), errorData); -    } else if (e instanceof ProcessExecutionException) { -      // send HTML formated error message -      writeHtmlErrorResponse(req, resp, e.getMessage(), internalErrorCode, null, -          statusMessager.mapInternalErrorToExternalError(internalErrorCode)); +    } else { +      // write generic message for general exceptions +      final String msg = statusMessager.getMessage(IStatusMessenger.CODES_INTERNAL_ERROR_GENERIC, null); +      writeHtmlErrorResponse(req, resp, msg, internalErrorCode, null, +          statusMessager.mapInternalErrorToExternalError(internalErrorCode), errorData);      } -    }    private IGuiBuilderConfiguration evaluateRequiredErrorHandlingMethod(IRequest first, String errorId) {      if (first != null && first.isProcessInIframe()) { -      return guiConfigFactory.getDefaultIFrameParentHopGui(first, -          ProtocolFinalizationController.ENDPOINT_ERRORHANDLING, -          errorId); +      return guiConfigFactory +          .getDefaultIFrameParentHopGui(first, "/" + ProtocolFinalizationController.ENDPOINT_ERRORHANDLING, errorId);      } -      return null;    } diff --git a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/controller/ProtocolFinalizationController.java b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/controller/ProtocolFinalizationController.java index b2130fb4..a8b0a961 100644 --- a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/controller/ProtocolFinalizationController.java +++ b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/controller/ProtocolFinalizationController.java @@ -15,7 +15,7 @@   * This product combines work with different licenses. See the "NOTICE" text file for details on the   * various modules and licenses. The "NOTICE" text file is part of the distribution. Any derivative   * works that you distribute must include a readable copy of the "NOTICE" text file. -*/ + */  package at.gv.egiz.eaaf.core.impl.idp.controller; @@ -39,15 +39,16 @@ import at.gv.egiz.eaaf.core.api.IRequestStorage;  import at.gv.egiz.eaaf.core.api.IStatusMessenger;  import at.gv.egiz.eaaf.core.api.data.EaafConstants;  import at.gv.egiz.eaaf.core.api.data.ExceptionContainer; +import at.gv.egiz.eaaf.core.api.idp.IModulInfo;  import at.gv.egiz.eaaf.core.api.utils.IPendingRequestIdGenerationStrategy;  import at.gv.egiz.eaaf.core.exceptions.EaafException; +import at.gv.egiz.eaaf.core.impl.idp.auth.services.ProtocolAuthenticationService;  import at.gv.egiz.eaaf.core.impl.utils.TransactionIdUtils;  /**   * Protocol finialization end-point.   *   * @author tlenz - *   */  @Controller  public class ProtocolFinalizationController extends AbstractController { @@ -56,10 +57,72 @@ public class ProtocolFinalizationController extends AbstractController {        EaafConstants.ENDPOINT_PREFIX_SECURED + "/finalizeAuthProtocol";    public static final String ENDPOINT_ERRORHANDLING =         EaafConstants.ENDPOINT_PREFIX_SECURED + "/errorHandling"; +  public static final String ENDPOINT_ERROR_REDIRECT =  +      EaafConstants.ENDPOINT_PREFIX_SECURED + "/errorRedirect";    @Autowired(required = true)    IRequestStorage requestStorage; -  @Autowired IPendingRequestIdGenerationStrategy requestIdValidationStragegy; +  @Autowired +  IPendingRequestIdGenerationStrategy requestIdValidationStragegy; + + +  /** +   * Handles incoming requests for redirects to IDP. +   * @param req  http request +   * @param resp http response +   * @throws EaafException In case of an internal error +   * @throws IOException   In case of a servlet error +   */ +  @RequestMapping(value = ENDPOINT_ERROR_REDIRECT, method = {RequestMethod.GET, RequestMethod.POST}) +  public void errorRedirect(final HttpServletRequest req, final HttpServletResponse resp) +      throws EaafException, IOException { + +    final String errorToken = StringEscapeUtils.escapeHtml4(req.getParameter(EaafConstants.PARAM_HTTP_ERROR_CODE)); +    if (errorToken != null) { +      IRequest pendingReq = null; +      try { +        String errorId = requestIdValidationStragegy.validateAndGetPendingRequestId(errorToken); +        log.debug("Searching exception with internal error-token: {}", errorId); + +        // load stored exception from database +        final byte[] containerSerialized = transactionStorage.get(errorId, byte[].class); +        if (containerSerialized != null) { +          // remove exception if it was found +          transactionStorage.remove(errorId); +          log.trace("Find exception with internal error-token: {}", errorId); + +          //final Object containerObj = EaafSerializationUtils.deserialize(containerSerialized, +          //    Arrays.asList( +          //        ExceptionContainer.class.getName() +          //        )); +          final Object containerObj = SerializationUtils.deserialize(containerSerialized); + +          if (containerObj instanceof ExceptionContainer) { +            final ExceptionContainer container = (ExceptionContainer) containerObj; +            final Throwable throwable = container.getExceptionThrown(); +            pendingReq = container.getPendingRequest(); + +            if (pendingReq != null) { +              IModulInfo handlingModule = ProtocolAuthenticationService +                  .extractShibbolethHandling(pendingReq, applicationContext); + +              handlingModule.generateErrorMessage(throwable, req, resp, pendingReq); +            } +          } +        } +      } catch (Throwable e) { +        log.error(e.getMessage(), e); +        protAuthService.handleErrorNoRedirect(e, req, resp, false); +      } finally { +        // remove pending-request +        if (pendingReq != null) { +          requestStorage.removePendingRequest(pendingReq.getPendingRequestId()); +          revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, pendingReq.getUniqueTransactionIdentifier()); + +        } +      } +    } +  }    /**     * End-Point to handle errors. @@ -69,32 +132,30 @@ public class ProtocolFinalizationController extends AbstractController {     * @throws EaafException In case of an internal error     * @throws IOException   In case of a servlet error     */ -  @RequestMapping(value = ENDPOINT_ERRORHANDLING, method = { RequestMethod.GET, RequestMethod.POST }) +  @RequestMapping(value = ENDPOINT_ERRORHANDLING, method = {RequestMethod.GET, RequestMethod.POST})    public void errorHandling(final HttpServletRequest req, final HttpServletResponse resp)        throws EaafException, IOException {      // receive an authentication error -    final String errorToken = -        StringEscapeUtils.escapeHtml4(req.getParameter(EaafConstants.PARAM_HTTP_ERROR_CODE)); +    final String errorToken = StringEscapeUtils.escapeHtml4(req.getParameter(EaafConstants.PARAM_HTTP_ERROR_CODE));      if (errorToken != null) {        IRequest pendingReq = null; -      try {        -        String errorId = requestIdValidationStragegy.validateAndGetPendingRequestId(errorToken);                 +      try { +        String errorId = requestIdValidationStragegy.validateAndGetPendingRequestId(errorToken);          log.debug("Searching exception with internal error-token: {}", errorId); -         +          // load stored exception from database -        final byte[] containerSerialized = -            transactionStorage.get(errorId, byte[].class); +        final byte[] containerSerialized = transactionStorage.get(errorId, byte[].class);          if (containerSerialized != null) {            // remove exception if it was found            transactionStorage.remove(errorId);            log.trace("Find exception with internal error-token: {}", errorId); -           +            //final Object containerObj = EaafSerializationUtils.deserialize(containerSerialized,             //    Arrays.asList(            //        ExceptionContainer.class.getName()            //        ));            final Object containerObj = SerializationUtils.deserialize(containerSerialized); -           +            if (containerObj instanceof ExceptionContainer) {              final ExceptionContainer container = (ExceptionContainer) containerObj;              final Throwable throwable = container.getExceptionThrown(); @@ -103,7 +164,7 @@ public class ProtocolFinalizationController extends AbstractController {              if (pendingReq != null) {                //set MDC variables                TransactionIdUtils.setAllLoggingVariables(pendingReq); -               +                // build protocol-specific error message if possible                protAuthService.buildProtocolSpecificErrorResponse(throwable, req, resp, pendingReq); @@ -116,17 +177,17 @@ public class ProtocolFinalizationController extends AbstractController {              }            } else { -            protAuthService.handleErrorNoRedirect( -                new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_GENERIC, null), -                req, resp, false); +            protAuthService +                .handleErrorNoRedirect(new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_GENERIC, null), req, +                    resp, false);            }          } else {            log.info("Find no exception with internal error-token: {}", errorId); -          protAuthService.handleErrorNoRedirect( -              new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_NOPENDIGREQID, null), -              req, resp, false); +          protAuthService +              .handleErrorNoRedirect(new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_NOPENDIGREQID, null), +                  req, resp, false);          } @@ -138,11 +199,10 @@ public class ProtocolFinalizationController extends AbstractController {          // remove pending-request          if (pendingReq != null) {            requestStorage.removePendingRequest(pendingReq.getPendingRequestId()); -          revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, -              pendingReq.getUniqueTransactionIdentifier()); +          revisionsLogger.logEvent(EventConstants.TRANSACTION_DESTROYED, pendingReq.getUniqueTransactionIdentifier());          } -         +          //remove all Logger variables          TransactionIdUtils.removeAllLoggingVariables(); @@ -150,9 +210,9 @@ public class ProtocolFinalizationController extends AbstractController {      } else {        log.debug("Request contains NO ErrorId"); -      protAuthService.handleErrorNoRedirect( -          new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_NOPENDIGREQID, null), req, -          resp, false); +      protAuthService +          .handleErrorNoRedirect(new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_NOPENDIGREQID, null), req, +              resp, false);      } @@ -166,7 +226,7 @@ public class ProtocolFinalizationController extends AbstractController {     * @throws EaafException In case of an internal error     * @throws IOException   In case of a servlet error     */ -  @RequestMapping(value = ENDPOINT_FINALIZEPROTOCOL, method = { RequestMethod.GET }) +  @RequestMapping(value = ENDPOINT_FINALIZEPROTOCOL, method = {RequestMethod.GET})    public void finalizeAuthProtocol(final HttpServletRequest req, final HttpServletResponse resp)        throws EaafException, IOException { @@ -179,19 +239,18 @@ public class ProtocolFinalizationController extends AbstractController {        log.info("PendingReqId was valid but no PendingRequest with ID: {}. Looks already used",             pendingRequestID);        protAuthService.handleErrorNoRedirect( -          new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_TIMEOUT, -              new Object[] { pendingRequestID, }), -          req, resp, false); +          new EaafException(IStatusMessenger.CODES_INTERNAL_ERROR_AUTH_TIMEOUT, new Object[]{pendingRequestID,}), req, +          resp, false);      } else {        //set MDC variables        TransactionIdUtils.setAllLoggingVariables(pendingReq); -       +        //perform protocol finalization steps        protAuthService.finalizeAuthentication(req, resp, pendingReq); -                   +      } -     +    }  } | 
