summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas <>2024-08-07 09:10:57 +0200
committerThomas <>2024-08-07 09:10:57 +0200
commitd140efeaa939a6dff3182cdfd5f4f7ca87a6b5b1 (patch)
tree25c517515ecd3cfe5723763010226a8d3d6a8a20
parent4fcb0654e81a0e3abf400dbbbd8d2bedbbf5864d (diff)
downloadEAAF-Components-d140efeaa939a6dff3182cdfd5f4f7ca87a6b5b1.tar.gz
EAAF-Components-d140efeaa939a6dff3182cdfd5f4f7ca87a6b5b1.tar.bz2
EAAF-Components-d140efeaa939a6dff3182cdfd5f4f7ca87a6b5b1.zip
fix(core): add authURL validation on error-page rendering too
-rw-r--r--eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java16
1 files changed, 12 insertions, 4 deletions
diff --git a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java
index 65041c92..4ec9f028 100644
--- a/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java
+++ b/eaaf_core/src/main/java/at/gv/egiz/eaaf/core/impl/idp/auth/services/ProtocolAuthenticationService.java
@@ -518,11 +518,9 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer
@NonNull final HttpServletResponse httpResp, @NonNull final String msg, @NonNull final String errorCode,
@Nullable final Object[] params, String externalErrorCode, IErrorService.IHandleData errorData)
throws EaafException {
-
try {
- final IGuiBuilderConfiguration config = guiConfigFactory
- .getDefaultErrorGui(HttpUtils.extractAuthUrlStringFromRequest(httpReq));
-
+ final IGuiBuilderConfiguration config = guiConfigFactory.getDefaultErrorGui(
+ getValidatedAuthUrl(httpReq));
String[] errorCodeParams = null;
if (params == null) {
@@ -628,4 +626,14 @@ public class ProtocolAuthenticationService implements IProtocolAuthenticationSer
}
+ private String getValidatedAuthUrl(HttpServletRequest httpReq) {
+ try {
+ return authConfig.validateIdpUrl(HttpUtils.extractAuthUrlFromRequest(httpReq));
+
+ } catch (EaafException e) {
+ log.warn("Request URL validation failed. Does not use it", e);
+ return "not://defined";
+
+ }
+ }
}